Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

default ipv6 subnet to /56 #1903

Merged
merged 2 commits into from
Oct 20, 2020
Merged

default ipv6 subnet to /56 #1903

merged 2 commits into from
Oct 20, 2020

Conversation

aojea
Copy link
Contributor

@aojea aojea commented Oct 20, 2020 •
edited
Loading

we were defaulting IPv6 subnet to a /64, this was working because
kubeadm was calculating and modifying directly the node-cidr-mask,
so the controller manager does not complain.

Kubeadm should only validate that the config is correct and fail
in case of error, this behavior will be changed soon, but once
this happen it will break kind default deployment.

xref: kubernetes/kubernetes#95723

Antonio Ojea added 2 commits October 20, 2020 18:14
default ipv6 subnet to /56
60074a9 
we were defaulting IPv6 subnet to a /64, this was working because
kubeadm was calculating and modifying directly the node-cidr-mask,
so the controller manager does not complain.

Kubeadm should only validate that the config is correct and fail
in case of error, this behavior will be changed soon, but once
this happen it will break kind default deployment.
sync apis defaults
f5e7483
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 20, 2020
@k8s-ci-robot k8s-ci-robot requested review from amwat and munnerz October 20, 2020 16:19
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 20, 2020
@aojea
Copy link
Contributor Author

aojea commented Oct 20, 2020

/assign @BenTheElder @neolit123

@BenTheElder
Copy link
Member

/approve
fun fun :+)

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, BenTheElder

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 20, 2020
@aojea aojea mentioned this pull request Oct 20, 2020
Merged
@aojea
Copy link
Contributor Author

aojea commented Oct 20, 2020

2020/10/20 16:21:34 Image pull was unsuccessful: unable to save remote image k8s.gcr.io/build-image/debian-iptables@sha256:e30919918299988b318f0208e7fd264dee21a6be9d74bbd9f7fc15e78eade9b4: unable to write image layers: unable to write image layer: unable to write the contents of layer 1 to /bazel-scratch/.cache/bazel/_bazel_root/cae228f2a89ef5ee47c2085e441a3561/external/debian-iptables-amd64/image/001.tar.gz: read tcp 10.60.181.111:51148->108.177.112.128:443: read: connection reset by peer

is not the first time I see this

@aojea
Copy link
Contributor Author

aojea commented Oct 20, 2020

/retest

@neolit123
Copy link
Member

neolit123 commented Oct 20, 2020 •
edited
Loading

xref: kubernetes/kubernetes#95723

maybe we should hold until that PR is merged, its a breaking change for ipv6 users as far as i can tell, so i'd appreciate more feedback on the PR.

/hold
?

EDIT: hm, so this PR is actually blocking the other PR due to CI.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 20, 2020
@aojea
Copy link
Contributor Author

aojea commented Oct 20, 2020 •
edited
Loading

maybe we should hold until that PR is merged, its a breaking change for ipv6 users as far as i can tell, so i'd appreciate more feedback on the PR.

/hold

is the other way around, we can not merge the other without this, and this is not breaking change since we only change the default ipv6 subnet in kind only, that has not any external dependencies

@neolit123
Copy link
Member

ok, feel free to remove hold.

@neolit123
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 20, 2020
@aojea
Copy link
Contributor Author

aojea commented Oct 20, 2020

Thanks Lubomir
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 20, 2020
@k8s-ci-robot k8s-ci-robot merged commit 237a031 into kubernetes-sigs:master Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amwat amwat Awaiting requested review from amwat

@munnerz munnerz Awaiting requested review from munnerz

Assignees

@neolit123 neolit123

@BenTheElder BenTheElder

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aojea @BenTheElder @k8s-ci-robot @neolit123