Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rollback containerd #1635

Merged
merged 3 commits into from
May 30, 2020
Merged

Rollback containerd #1635

merged 3 commits into from
May 30, 2020

Conversation

BenTheElder
Copy link
Member

to latest 1.3.X, not 1.4.x

fixes #1634

we're going to need to identify the breakage so we can eventually roll forward to 1.4.X when it comes out though, and this means we lose the fix for #1560

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 30, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from amwat and munnerz May 30, 2020 17:01
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 30, 2020
@BenTheElder BenTheElder mentioned this pull request May 30, 2020
Closed
@BenTheElder
Copy link
Member Author

/retest

1 similar comment
@BenTheElder
Copy link
Member Author

/retest

@k8s-ci-robot
Copy link
Contributor

@BenTheElder: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kind-conformance-parallel-ipv6 130282c link /test pull-kind-conformance-parallel-ipv6
pull-kind-e2e-kubernetes 130282c link /test pull-kind-e2e-kubernetes
pull-kind-e2e-kubernetes-1-18 130282c link /test pull-kind-e2e-kubernetes-1-18
pull-kind-conformance-parallel-1-15 130282c link /test pull-kind-conformance-parallel-1-15

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@BenTheElder BenTheElder merged commit ca0dde4 into kubernetes-sigs:master May 30, 2020
@BenTheElder BenTheElder deleted the rollback-containerd branch May 30, 2020 18:14
@aojea aojea mentioned this pull request Jun 2, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amwat amwat Awaiting requested review from amwat

@munnerz munnerz Awaiting requested review from munnerz

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot run kind from HEAD
2 participants
@BenTheElder @k8s-ci-robot