Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

install nfs common #1548

Merged
merged 2 commits into from
May 2, 2020
Merged

install nfs common #1548

merged 2 commits into from
May 2, 2020

Conversation

BenTheElder
Copy link
Member

this is necessary to enable NFS volumes, which should work on current kernels theoretically

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 2, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from aojea and neolit123 May 2, 2020 05:06
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 2, 2020
@BenTheElder
Copy link
Member Author

(only [Disruptive] nfs tests failed)

@BenTheElder
Copy link
Member Author

With the temp commit to force running specifically focus=\[Driver.nfs\] skip=\[Disruptive\]

master 32/32 ✔️
master (ipv6) 4/32 ❌
1.18 32/32 ✔️
1.17 32/32 ✔️
1.16 30/30 ✔️
1.15 68/68 ✔️

tests probably need fixing for ipv6 🙃

@BenTheElder
Copy link
Member Author

dropped the temp commit.

this change is relatively small and enables a bunch of storage tests, as well as being necessary for rwmany volumes on kind to be feasible. #1487

@BenTheElder BenTheElder merged commit 3fdc60f into kubernetes-sigs:master May 2, 2020
@BenTheElder BenTheElder deleted the nfs-common branch May 2, 2020 05:55
@BenTheElder BenTheElder added this to the v0.9.0 milestone May 2, 2020
@BenTheElder
Copy link
Member Author

locally ipv4, k8s 1.18.2:

Ran 32 of 4992 Specs in 1361.800 seconds
SUCCESS! -- 32 Passed | 0 Failed | 0 Pending | 4960 Skipped

going to check PersistentVolumes.NFS tests now

@BenTheElder
Copy link
Member Author

well some of them are uh slow, but those work too:

Ran 8 of 4992 Specs in 637.358 seconds
SUCCESS! -- 8 Passed | 0 Failed | 0 Pending | 4984 Skipped

@BenTheElder
Copy link
Member Author

kubernetes/test-infra#17492

@wouterh-dev
Copy link
Contributor

Would love to try kind with the nfs-provisioner. When will an updated kindest/node image be published for 1.13?

@BenTheElder
Copy link
Member Author

BenTheElder commented May 22, 2020 via email

@ghost ghost mentioned this pull request Sep 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aojea aojea Awaiting requested review from aojea

@neolit123 neolit123 Awaiting requested review from neolit123

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v0.9.0
Development

Successfully merging this pull request may close these issues.
3 participants
@BenTheElder @k8s-ci-robot @wouterh-dev