add a note about taint removal

kubernetes-sigs · Mar 12, 2019 · af80976 · af80976
1 parent 2ac298d
commit af80976
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 3 deletions.
diff --git a/pkg/cluster/config/types.go b/pkg/cluster/config/types.go
@@ -75,7 +75,9 @@ type NodeRole string
 
 const (
 	// ControlPlaneRole identifies a node that hosts a Kubernetes control-plane.
-	// NOTE: in single node clusters, control-plane nodes act also as a worker nodes
+	// NOTE: in single node clusters, control-plane nodes act also as a worker
+	// nodes, in which case the taint will be removed. see:
+	// https://kubernetes.io/docs/setup/independent/create-cluster-kubeadm/#control-plane-node-isolation
 	ControlPlaneRole NodeRole = "control-plane"
 	// WorkerRole identifies a node that hosts a Kubernetes worker
 	WorkerRole NodeRole = "worker"

diff --git a/pkg/cluster/config/v1alpha2/types.go b/pkg/cluster/config/v1alpha2/types.go
@@ -68,7 +68,9 @@ type NodeRole string
 
 const (
 	// ControlPlaneRole identifies a node that hosts a Kubernetes control-plane.
-	// NB. in single node clusters, control-plane nodes act also as a worker nodes
+	// NOTE: in single node clusters, control-plane nodes act also as a worker
+	// nodes, in which case the taint will be removed. see:
+	// https://kubernetes.io/docs/setup/independent/create-cluster-kubeadm/#control-plane-node-isolation
 	ControlPlaneRole NodeRole = "control-plane"
 	// WorkerRole identifies a node that hosts a Kubernetes worker
 	WorkerRole NodeRole = "worker"

diff --git a/pkg/cluster/config/v1alpha3/types.go b/pkg/cluster/config/v1alpha3/types.go
@@ -75,7 +75,9 @@ type NodeRole string
 
 const (
 	// ControlPlaneRole identifies a node that hosts a Kubernetes control-plane.
-	// NOTE: in single node clusters, control-plane nodes act also as a worker nodes
+	// NOTE: in single node clusters, control-plane nodes act also as a worker
+	// nodes, in which case the taint will be removed. see:
+	// https://kubernetes.io/docs/setup/independent/create-cluster-kubeadm/#control-plane-node-isolation
 	ControlPlaneRole NodeRole = "control-plane"
 	// WorkerRole identifies a node that hosts a Kubernetes worker
 	WorkerRole NodeRole = "worker"