disable smart output in st

kubernetes-sigs · Nov 12, 2020 · 9062972 · 9062972
1 parent e7d1a7d
commit 9062972
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/pkg/internal/env/term.go b/pkg/internal/env/term.go
@@ -68,7 +68,13 @@ func isSmartTerminal(w io.Writer, GOOS string, lookupEnv func(string) (string, b
 
 	// Explicitly dumb terminals are not smart
 	// https://en.wikipedia.org/wiki/Computer_terminal#Dumb_terminals
-	if getenv("TERM") == "dumb" {
+	term := getenv("TERM")
+	if term == "dumb" {
+		return false
+	}
+	// st has some bug 🤷‍♂️
+	// https://github.com/kubernetes-sigs/kind/issues/1892
+	if term == "st-256color" {
 		return false
 	}
 

diff --git a/pkg/internal/env/term_test.go b/pkg/internal/env/term_test.go
@@ -117,6 +117,15 @@ func TestIsSmartTerminal(t *testing.T) {
 			IsSmart: false,
 			Writer:  &testFakeTTY{},
 		},
+		{
+			Name: "tty, TERM=st-256color",
+			FakeEnv: map[string]string{
+				"TERM": "st-256color",
+			},
+			GOOS:    "linux",
+			IsSmart: false,
+			Writer:  &testFakeTTY{},
+		},
 	}
 	for _, tc := range cases {
 		tc := tc // capture tc