address comments

pkg/cluster/config/helpers.go

@@ -24,6 +24,7 @@ import (
 )
 
 // IsControlPlane returns true if the node hosts a control plane instance
+// NB. in single node clusters, control-plane nodes act also as a worker nodes
 func (n *Node) IsControlPlane() bool {
 	return n.Role == ControlPlaneRole
 }

pkg/cluster/config/types.go

@@ -80,17 +80,14 @@ type Node struct {
 	// This information is internal to `kind`.
 	// +k8s:conversion-gen=false
 	Name string
-	// ContainerHandle provides an handle to the container implementing the node
-	// This information is internal to `kind`.
-	// +k8s:conversion-gen=false
-	ContainerHandle
 }
 
 // NodeRole defines possible role for nodes in a Kubernetes cluster managed by `kind`
 type NodeRole string
 
 const (
 	// ControlPlaneRole identifies a node that hosts a Kubernetes control-plane
+	// NB. in single node clusters, control-plane nodes act also as a worker nodes
 	ControlPlaneRole NodeRole = "control-plane"
 	// WorkerRole identifies a node that hosts a Kubernetes worker
 	WorkerRole NodeRole = "worker"
@@ -154,12 +151,3 @@ type derivedConfigData struct {
 	// externalLoadBalancer contains the node with external-load-balancer role, if defined
 	externalLoadBalancer *Node
 }
-
-// +k8s:conversion-gen=false
-
-// ContainerHandle defines info used by `kind` for transforming Nodes into containers.
-// This struct is used internally by `kind` and it is NOT EXPOSED as a object of the public API.
-// TODO(fabriziopandini): this is a place holder for an object that will replace current container handle
-// when pkg/cluster/context.go will support multi master
-type ContainerHandle struct {
-}

pkg/cluster/config/v1alpha2/types.go

@@ -55,7 +55,8 @@ type Node struct {
 type NodeRole string
 
 const (
-	// ControlPlaneRole identifies a node that hosts a Kubernetes control-plane
+	// ControlPlaneRole identifies a node that hosts a Kubernetes control-plane.
+	// NB. in single node clusters, control-plane nodes act also as a worker nodes
 	ControlPlaneRole NodeRole = "control-plane"
 	// WorkerRole identifies a node that hosts a Kubernetes worker
 	WorkerRole NodeRole = "worker"