Skip to content

Commit

Permalink
use infinity for LimitNOFILE
Browse files Browse the repository at this point in the history
  • Loading branch information
@BenTheElder
BenTheElder committed Aug 21, 2020
1 parent c5891e6 commit 2f17d25
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion images/base/files/etc/systemd/system/containerd.service
View file
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ Restart=always
# in the kernel. We recommend using cgroups to do container-local accounting.
LimitNPROC=infinity
LimitCORE=infinity
LimitNOFILE=1048576
LimitNOFILE=infinity
# Comment TasksMax if your systemd version does not supports it.
# Only systemd 226 and above support this version.
TasksMax=infinity
Expand Down

2 comments on commit 2f17d25

@thomasjm
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BenTheElder I have a question about this old commit... it seems like it reverts the intention of this previous PR: #760.

That PR explained why explicitly setting the LimitNOFILE is a good idea -- it improves reproducibility because some applications don't perform well with some limits. (Either too low or too high of a limit can cause problems.)

Any chance you could comment on why this was changed? Thanks!

@BenTheElder
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see the PR instead of the detached commit #1799 (comment)

Please sign in to comment.