-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: emit pod nomination events and add provisioning node tainted trigger controller #933
Conversation
fe4bae4
to
6f5db86
Compare
03f0a07
to
f93c87c
Compare
6a86347
to
125389e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
4a572e0
to
8e66a9d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jonathan-innis, njtran The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/remove-hold |
Fixes #N/A
Description
This is a breaking change for users that rely on messages emitted by the
provisioning.trigger
controller in their logging. This adds another reconciler so that the provisioning trigger consists of aprovisioning.nodetrigger
which will trigger the batching mechanism for any tainted nodes, andprovisioning.podtrigger
which is the same as theprovisioning.trigger
.This fixes an issue where successive disruption controller reconciliations wouldn't consider the results of the previous (and currently active) disruption command. This could result in Karpenter disrupting a node that was recently the target of a scheduling loop, when Karpenter should really wait and consider another node for disruption.
How was this change tested?
make presubmit
kwok cloud provider
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.