Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix kind cluster test cleanup flakes #1399

Merged
merged 5 commits into from
Jul 8, 2024
Merged

test: fix kind cluster test cleanup flakes #1399

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a1bab96
fixTests
njtran Jul 8, 2024
77826ac
remove foreground
njtran Jul 8, 2024
356fd4a
reorder
njtran Jul 8, 2024
e128d08
fix order of deletion
njtran Jul 8, 2024
2e9c40d
removecomment
njtran Jul 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion hack/install-kwok.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,8 +112,8 @@ crdURL="https://github.com/${KWOK_REPO}/releases/download/${KWOK_RELEASE}/stage-
# Set UNINSTALL_KWOK=true if you want to uninstall.
if [[ ${UNINSTALL_KWOK} = "true" ]]
then
kubectl delete -f ${HOME_DIR}/kwok.yaml
kubectl delete -f ${crdURL}
kubectl delete -f ${HOME_DIR}/kwok.yaml
else
kubectl apply -f ${HOME_DIR}/kwok.yaml
kubectl apply -f ${crdURL}
Expand Down
1 change: 0 additions & 1 deletion test/pkg/environment/common/setup.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,6 @@ func (env *Environment) CleanupObjects(cleanableObjects ...client.Object) {
defer GinkgoRecover()
g.Expect(env.ExpectTestingFinalizerRemoved(&metaList.Items[i])).To(Succeed())
g.Expect(client.IgnoreNotFound(env.Client.Delete(env, &metaList.Items[i],
ellistarn marked this conversation as resolved.
Show resolved Hide resolved
client.PropagationPolicy(metav1.DeletePropagationForeground),
&client.DeleteOptions{GracePeriodSeconds: lo.ToPtr(int64(0))}))).To(Succeed())
})
// If the deletes eventually succeed, we should have no elements here at the end of the test
Expand Down
Loading