Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix e2e tests assertion #1395

Merged
merged 1 commit into from
Jul 5, 2024
Merged

Conversation

njtran
Copy link
Contributor

@njtran njtran commented Jul 5, 2024

Fixes #N/A

Description
Fixes a test assertion due to rounding errors

How was this change tested?
make e2etests with a kwok cluster

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@k8s-ci-robot k8s-ci-robot requested review from engedaam and tallaxes July 5, 2024 23:37
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: njtran

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 5, 2024
@coveralls
Copy link

coveralls commented Jul 5, 2024

Pull Request Test Coverage Report for Build 9814685986

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 6 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.05%) to 78.236%

Files with Coverage Reduction New Missed Lines %
pkg/test/expectations/expectations.go 2 93.71%
pkg/scheduling/requirements.go 2 98.01%
pkg/controllers/node/termination/controller.go 2 59.81%
Totals Coverage Status
Change from base Build 9814599559: -0.05%
Covered Lines: 8969
Relevant Lines: 11464

💛 - Coveralls

@jmdeal
Copy link
Member

jmdeal commented Jul 5, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 5, 2024
@k8s-ci-robot k8s-ci-robot merged commit 9c012d6 into kubernetes-sigs:main Jul 5, 2024
13 checks passed
@njtran njtran deleted the testAssert branch July 5, 2024 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants