test: update node termination test to model eventual removal

[jmdeal]

Fixes #N/A

Description
Updates the node/termination test suite to properly model eventual removal now that it may take multiple reconciliations.

How was this change tested?
make test

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[k8s-ci-robot]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[coveralls]

Pull Request Test Coverage Report for Build 9521007078

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• 2 unchanged lines in 1 file lost coverage.
• Overall coverage remained the same at 81.267%

---

Files with Coverage Reduction	New Missed Lines	%
pkg/test/expectations/expectations.go	2	93.69%

Totals
Change from base Build 9492890501:	0.0%
Covered Lines:	8299
Relevant Lines:	10212

---

💛 - Coveralls

[jonathan-innis]

Can you talk with @jigisha620 on this one? I'm surprised that the changes that were made in the other PR didn't cause failures in these tests and we're having to make these changes after the fact now.

Can you clarify what is failing that wasn't properly captured through testing?

[jmdeal]

Already spoke with her offline about it, the gist of the problem is that the node termination controller can now take multiple reconciliations to delete the node. It didn't before because there was never a nodeclaim associated with the node, so it immediately deleted. IMO since it can now take multiple reconciliations this is the correct way to model it and unblocks some issues upon rebase in #916 since it applied the nodeclaim.

[jigisha620]

Can you clarify what is failing that wasn't properly captured through testing?

There wasn't a nodeClaim associated with a node in the tests that we had and that's why there was no failure. This wasn't captured until #916 applied nodeClaim and started seeing the failures.

[jigisha620]

LGTM 🚀

[coveralls]

Pull Request Test Coverage Report for Build 9522800263

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

• For more information on this, see Tracking coverage changes with pull request builds.
• To avoid this issue with future PRs, see these Recommended CI Configurations.
• For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• 2 unchanged lines in 1 file lost coverage.
• Overall coverage increased (+0.09%) to 81.355%

---

Files with Coverage Reduction	New Missed Lines	%
pkg/controllers/disruption/drift.go	2	89.29%

Totals
Change from base Build 9492890501:	0.09%
Covered Lines:	8308
Relevant Lines:	10212

---

💛 - Coveralls

[coveralls]

Pull Request Test Coverage Report for Build 9523915252

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

• For more information on this, see Tracking coverage changes with pull request builds.
• To avoid this issue with future PRs, see these Recommended CI Configurations.
• For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.1%) to 81.375%

---

Totals
Change from base Build 9492890501:	0.1%
Covered Lines:	8310
Relevant Lines:	10212

---

💛 - Coveralls

[jonathan-innis]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jigisha620, jmdeal, jonathan-innis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jonathan-innis]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[coveralls]

Pull Request Test Coverage Report for Build 9523995887

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

• For more information on this, see Tracking coverage changes with pull request builds.
• To avoid this issue with future PRs, see these Recommended CI Configurations.
• For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• 2 unchanged lines in 1 file lost coverage.
• Overall coverage increased (+0.07%) to 81.336%

---

Files with Coverage Reduction	New Missed Lines	%
pkg/test/expectations/expectations.go	2	93.69%

Totals
Change from base Build 9492890501:	0.07%
Covered Lines:	8306
Relevant Lines:	10212

---

💛 - Coveralls

[coveralls]

Pull Request Test Coverage Report for Build 9524005690

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

• For more information on this, see Tracking coverage changes with pull request builds.
• To avoid this issue with future PRs, see these Recommended CI Configurations.
• For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• 2 unchanged lines in 1 file lost coverage.
• Overall coverage increased (+0.09%) to 81.355%

---

Files with Coverage Reduction	New Missed Lines	%
pkg/controllers/provisioning/scheduling/nodeclaim.go	2	89.13%

Totals
Change from base Build 9492890501:	0.09%
Covered Lines:	8308
Relevant Lines:	10212

---

💛 - Coveralls