-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: create constraints on offerings #1262
feat: create constraints on offerings #1262
Conversation
Welcome @rschalo! |
Hi @rschalo. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
7687440
to
e6beb93
Compare
Pull Request Test Coverage Report for Build 9212879269Details
💛 - Coveralls |
080ade8
to
acb7442
Compare
acb7442
to
372e95c
Compare
pkg/controllers/provisioning/scheduling/instance_selection_test.go
Outdated
Show resolved
Hide resolved
pkg/controllers/provisioning/scheduling/instance_selection_test.go
Outdated
Show resolved
Hide resolved
372e95c
to
e18fc22
Compare
/assign @jmdeal |
e18fc22
to
e29ecad
Compare
957333a
to
03c669c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment, otherwise lgtm
25439a5
to
de6cbd1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jonathan-innis, njtran, rschalo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Fixes
aws/karpenter-provider-aws#3878
aws/karpenter-provider-aws#4612
Description
This change allows cloudprovider specific constraints to be added to Offering. Zone and capacityType are special labels that are used across the Karpenter codebase.
How was this change tested?
There shouldn't be the need for new tests as long as the current test suite passes. There will be additional tests required in karpenter-aws-provider in order to validate additional constraints. Starting this draft PR for discussion.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.