Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add kind cluster gha #1234

Merged
merged 23 commits into from
May 9, 2024
Merged

Conversation

njtran
Copy link
Contributor

@njtran njtran commented May 6, 2024

Fixes #N/A

Description
This stages a workflow to be able to run the kwok controller in kind clusters. This just sets up the environment and applies some well known addons that we'll need. We won't be running this on presubmit as to not create kind clusters without actually running any tests on them.

How was this change tested?
testing GHA on my own fork

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 6, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: njtran

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 6, 2024
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented May 6, 2024

Pull Request Test Coverage Report for Build 9010023859

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.07%) to 78.593%

Totals Coverage Status
Change from base Build 9010010244: 0.07%
Covered Lines: 8356
Relevant Lines: 10632

💛 - Coveralls

@njtran njtran changed the title Kind action feat: add kind cluster gha May 6, 2024
@Bryce-Soghigian
Copy link
Member

83430a8 shouldwork

Let us pray it does :)

@engedaam
Copy link
Contributor

engedaam commented May 8, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 8, 2024
@k8s-ci-robot k8s-ci-robot merged commit ea25c3e into kubernetes-sigs:main May 9, 2024
12 checks passed
@njtran njtran deleted the kindAction branch May 9, 2024 01:23
jonathan-innis pushed a commit that referenced this pull request May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants