chore: migrate knative logger to controller-runtime injected logger #1050

fmuyassarov · 2024-02-28T11:25:11Z

Fixes: #922

Description
Migrate knative logger to controller-runtime injected logger

After this change the logging messages look like below

{"level":"info","ts":"2024-03-14T10:13:26Z","logger":"controller","msg":"discovered karpenter version","version":"unspecified"}
{"level":"info","ts":"2024-03-14T10:13:26Z","logger":"controller","msg":"webhook disabled"}
{"level":"info","ts":"2024-03-14T10:13:26Z","logger":"controller-runtime.metrics","msg":"Starting metrics server"}
{"level":"info","ts":"2024-03-14T10:13:26Z","logger":"controller-runtime.metrics","msg":"Serving metrics server","bindAddress":":8000","secure":false}
{"level":"info","ts":"2024-03-14T10:13:26Z","logger":"controller","msg":"starting server","kind":"health probe","addr":"[::]:8081"}
{"level":"info","ts":1710411206.3906345,"logger":"fallback","caller":"leaderelection/leaderelection.go:250","msg":"attempting to acquire leader lease kube-system/karpenter-leader-election..."}
{"level":"info","ts":1710411221.86726,"logger":"fallback","caller":"leaderelection/leaderelection.go:260","msg":"successfully acquired lease kube-system/karpenter-leader-election"}
{"level":"info","ts":"2024-03-14T10:13:41Z","logger":"controller.provisioner","msg":"starting controller"}
{"level":"info","ts":"2024-03-14T10:13:41Z","logger":"controller.disruption.queue","msg":"starting controller"}
{"level":"info","ts":"2024-03-14T10:13:41Z","logger":"controller.eviction-queue","msg":"starting controller"}
{"level":"info","ts":"2024-03-14T10:13:41Z","logger":"controller","msg":"Starting EventSource","controller":"provisioner.trigger.pod","controllerGroup":"","controllerKind":"Pod","source":"kind source: *v1.Pod"}
{"level":"info","ts":"2024-03-14T10:13:41Z","logger":"controller","msg":"Starting Controller","controller":"provisioner.trigger.pod","controllerGroup":"","controllerKind":"Pod"}
{"level":"info","ts":"2024-03-14T10:13:41Z","logger":"controller","msg":"Starting workers","controller":"provisioner.trigger.pod","controllerGroup":"","controllerKind":"Pod","worker count":10}
{"level":"info","ts":"2024-03-14T10:13:41Z","logger":"controller.disruption","msg":"starting controller"}
{"level":"info","ts":"2024-03-14T10:13:41Z","logger":"controller","msg":"Starting EventSource","controller":"nodepool.hash","controllerGroup":"karpenter.sh","controllerKind":"NodePool","source":"kind source: *v1beta1.NodePool"}
{"level":"info","ts":"2024-03-14T10:13:41Z","logger":"controller","msg":"Starting Controller","controller":"nodepool.hash","controllerGroup":"karpenter.sh","controllerKind":"NodePool"}
{"level":"info","ts":"2024-03-14T10:13:41Z","logger":"controller","msg":"Starting EventSource","controller":"provisioner.trigger.node","controllerGroup":"","controllerKind":"Node","source":"kind source: *v1.Node"}
{"level":"info","ts":"2024-03-14T10:13:41Z","logger":"controller","msg":"Starting Controller","controller":"provisioner.trigger.node","controllerGroup":"","controllerKind":"Node"}
{"level":"info","ts":"2024-03-14T10:13:41Z","logger":"controller","msg":"Starting EventSource","controller":"state.node","controllerGroup":"","controllerKind":"Node","source":"kind source: *v1.Node"}
{"level":"info","ts":"2024-03-14T10:13:41Z","logger":"controller","msg":"Starting Controller","controller":"state.node","controllerGroup":"","controllerKind":"Node"}
{"level":"info","ts":"2024-03-14T10:13:41Z","logger":"controller","msg":"Starting EventSource","controller":"state.daemonset","controllerGroup":"apps","controllerKind":"DaemonSet","source":"kind source: *v1.DaemonSet"}
{"level":"info","ts":"2024-03-14T10:13:41Z","logger":"controller","msg":"Starting Controller","controller":"state.daemonset","controllerGroup":"apps","controllerKind":"DaemonSet"}
{"level":"info","ts":"2024-03-14T10:13:41Z","logger":"controller","msg":"Starting EventSource","controller":"state.nodepool","controllerGroup":"karpenter.sh","controllerKind":"NodePool","source":"kind source: *v1beta1.NodePool"}
{"level":"info","ts":"2024-03-14T10:13:41Z","logger":"controller","msg":"Starting Controller","controller":"state.nodepool","controllerGroup":"karpenter.sh","controllerKind":"NodePool"}
{"level":"info","ts":"2024-03-14T10:13:41Z","logger":"controller","msg":"Starting EventSource","controller":"state.pod","controllerGroup":"","controllerKind":"Pod","source":"kind source: *v1.Pod"}
{"level":"info","ts":"2024-03-14T10:13:41Z","logger":"controller","msg":"Starting Controller","controller":"state.pod","controllerGroup":"","controllerKind":"Pod"}
{"level":"info","ts":"2024-03-14T10:13:41Z","logger":"controller","msg":"Starting EventSource","controller":"node.termination","controllerGroup":"","controllerKind":"Node","source":"kind source: *v1.Node"}
{"level":"info","ts":"2024-03-14T10:13:41Z","logger":"controller","msg":"Starting Controller","controller":"node.termination","controllerGroup":"","controllerKind":"Node"}
{"level":"info","ts":"2024-03-14T10:13:41Z","logger":"controller","msg":"Starting EventSource","controller":"state.nodeclaim","controllerGroup":"karpenter.sh","controllerKind":"NodeClaim","source":"kind source: *v1beta1.NodeClaim"}
{"level":"info","ts":"2024-03-14T10:13:41Z","logger":"controller","msg":"Starting Controller","controller":"state.nodeclaim","controllerGroup":"karpenter.sh","controllerKind":"NodeClaim"}
{"level":"info","ts":"2024-03-14T10:13:41Z","logger":"controller","msg":"Starting EventSource","controller":"metrics.nodepool","controllerGroup":"karpenter.sh","controllerKind":"NodePool","source":"kind source: *v1beta1.NodePool"}
{"level":"info","ts":"2024-03-14T10:13:41Z","logger":"controller","msg":"Starting Controller","controller":"metrics.nodepool","controllerGroup":"karpenter.sh","controllerKind":"NodePool"}
{"level":"info","ts":"2024-03-14T10:13:41Z","logger":"controller","msg":"Starting EventSource","controller":"metrics.pod","controllerGroup":"","controllerKind":"Pod","source":"kind source: *v1.Pod"}
{"level":"info","ts":"2024-03-14T10:13:41Z","logger":"controller","msg":"Starting Controller","controller":"metrics.pod","controllerGroup":"","controllerKind":"Pod"}
{"level":"info","ts":"2024-03-14T10:13:41Z","logger":"controller","msg":"Starting EventSource","controller":"nodepool.counter","controllerGroup":"karpenter.sh","controllerKind":"NodePool","source":"kind source: *v1beta1.NodePool"}
{"level":"info","ts":"2024-03-14T10:13:41Z","logger":"controller","msg":"Starting EventSource","controller":"nodepool.counter","controllerGroup":"karpenter.sh","controllerKind":"NodePool","source":"kind source: *v1beta1.NodeClaim"}
{"level":"info","ts":"2024-03-14T10:13:41Z","logger":"controller","msg":"Starting EventSource","controller":"nodepool.counter","controllerGroup":"karpenter.sh","controllerKind":"NodePool","source":"kind source: *v1.Node"}
{"level":"info","ts":"2024-03-14T10:13:41Z","logger":"controller","msg":"Starting Controller","controller":"nodepool.counter","controllerGroup":"karpenter.sh","controllerKind":"NodePool"}
{"level":"info","ts":"2024-03-14T10:13:41Z","logger":"controller.metrics.node","msg":"starting controller"}
{"level":"info","ts":"2024-03-14T10:13:41Z","logger":"controller","msg":"Starting EventSource","controller":"nodeclaim.lifecycle","controllerGroup":"karpenter.sh","controllerKind":"NodeClaim","source":"kind source: *v1beta1.NodeClaim"}
{"level":"info","ts":"2024-03-14T10:13:41Z","logger":"controller","msg":"Starting EventSource","controller":"nodeclaim.lifecycle","controllerGroup":"karpenter.sh","controllerKind":"NodeClaim","source":"kind source: *v1.Node"}
{"level":"info","ts":"2024-03-14T10:13:41Z","logger":"controller","msg":"Starting Controller","controller":"nodeclaim.lifecycle","controllerGroup":"karpenter.sh","controllerKind":"NodeClaim"}
{"level":"info","ts":"2024-03-14T10:13:41Z","logger":"controller","msg":"Starting EventSource","controller":"nodeclaim.consistency","controllerGroup":"karpenter.sh","controllerKind":"NodeClaim","source":"kind source: *v1beta1.NodeClaim"}
{"level":"info","ts":"2024-03-14T10:13:41Z","logger":"controller","msg":"Starting EventSource","controller":"nodeclaim.consistency","controllerGroup":"karpenter.sh","controllerKind":"NodeClaim","source":"kind source: *v1.Node"}
{"level":"info","ts":"2024-03-14T10:13:41Z","logger":"controller","msg":"Starting Controller","controller":"nodeclaim.consistency","controllerGroup":"karpenter.sh","controllerKind":"NodeClaim"}
{"level":"info","ts":"2024-03-14T10:13:41Z","logger":"controller","msg":"Starting EventSource","controller":"nodeclaim.termination","controllerGroup":"karpenter.sh","controllerKind":"NodeClaim","source":"kind source: *v1beta1.NodeClaim"}
{"level":"info","ts":"2024-03-14T10:13:41Z","logger":"controller","msg":"Starting EventSource","controller":"nodeclaim.termination","controllerGroup":"karpenter.sh","controllerKind":"NodeClaim","source":"kind source: *v1.Node"}
{"level":"info","ts":"2024-03-14T10:13:41Z","logger":"controller","msg":"Starting Controller","controller":"nodeclaim.termination","controllerGroup":"karpenter.sh","controllerKind":"NodeClaim"}
{"level":"info","ts":"2024-03-14T10:13:41Z","logger":"controller.nodeclaim.garbagecollection","msg":"starting controller"}
{"level":"info","ts":"2024-03-14T10:13:41Z","logger":"controller","msg":"Starting EventSource","controller":"lease.garbagecollection","controllerGroup":"coordination.k8s.io","controllerKind":"Lease","source":"kind source: *v1.Lease"}
{"level":"info","ts":"2024-03-14T10:13:41Z","logger":"controller","msg":"Starting Controller","controller":"lease.garbagecollection","controllerGroup":"coordination.k8s.io","controllerKind":"Lease"}
{"level":"info","ts":"2024-03-14T10:13:41Z","logger":"controller","msg":"Starting EventSource","controller":"nodeclaim.disruption","controllerGroup":"karpenter.sh","controllerKind":"NodeClaim","source":"kind source: *v1beta1.NodeClaim"}
{"level":"info","ts":"2024-03-14T10:13:41Z","logger":"controller","msg":"Starting EventSource","controller":"nodeclaim.disruption","controllerGroup":"karpenter.sh","controllerKind":"NodeClaim","source":"kind source: *v1beta1.NodePool"}
{"level":"info","ts":"2024-03-14T10:13:41Z","logger":"controller","msg":"Starting EventSource","controller":"nodeclaim.disruption","controllerGroup":"karpenter.sh","controllerKind":"NodeClaim","source":"kind source: *v1.Pod"}
{"level":"info","ts":"2024-03-14T10:13:41Z","logger":"controller","msg":"Starting Controller","controller":"nodeclaim.disruption","controllerGroup":"karpenter.sh","controllerKind":"NodeClaim"}
{"level":"info","ts":"2024-03-14T10:13:41Z","logger":"controller.disruption","msg":"waiting on cluster sync"}
{"level":"info","ts":"2024-03-14T10:13:41Z","logger":"controller","msg":"Starting workers","controller":"nodepool.hash","controllerGroup":"karpenter.sh","controllerKind":"NodePool","worker count":10}
{"level":"info","ts":"2024-03-14T10:13:41Z","logger":"controller","msg":"Starting workers","controller":"provisioner.trigger.node","controllerGroup":"","controllerKind":"Node","worker count":10}
{"level":"info","ts":"2024-03-14T10:13:41Z","logger":"controller","msg":"Starting workers","controller":"state.node","controllerGroup":"","controllerKind":"Node","worker count":10}
{"level":"info","ts":"2024-03-14T10:13:41Z","logger":"controller","msg":"Starting workers","controller":"state.nodepool","controllerGroup":"karpenter.sh","controllerKind":"NodePool","worker count":10}
{"level":"info","ts":"2024-03-14T10:13:41Z","logger":"controller","msg":"Starting workers","controller":"state.pod","controllerGroup":"","controllerKind":"Pod","worker count":10}
{"level":"info","ts":"2024-03-14T10:13:41Z","logger":"controller","msg":"Starting workers","controller":"node.termination","controllerGroup":"","controllerKind":"Node","worker count":100}
{"level":"info","ts":"2024-03-14T10:13:41Z","logger":"controller","msg":"Starting workers","controller":"state.nodeclaim","controllerGroup":"karpenter.sh","controllerKind":"NodeClaim","worker count":10}
{"level":"info","ts":"2024-03-14T10:13:41Z","logger":"controller","msg":"Starting workers","controller":"metrics.nodepool","controllerGroup":"karpenter.sh","controllerKind":"NodePool","worker count":1}
{"level":"info","ts":"2024-03-14T10:13:41Z","logger":"controller","msg":"Starting workers","controller":"metrics.pod","controllerGroup":"","controllerKind":"Pod","worker count":1}
{"level":"info","ts":"2024-03-14T10:13:41Z","logger":"controller","msg":"Starting workers","controller":"nodepool.counter","controllerGroup":"karpenter.sh","controllerKind":"NodePool","worker count":10}
{"level":"info","ts":"2024-03-14T10:13:41Z","logger":"controller","msg":"Starting workers","controller":"nodeclaim.lifecycle","controllerGroup":"karpenter.sh","controllerKind":"NodeClaim","worker count":1000}
{"level":"info","ts":"2024-03-14T10:13:41Z","logger":"controller","msg":"Starting workers","controller":"nodeclaim.consistency","controllerGroup":"karpenter.sh","controllerKind":"NodeClaim","worker count":10}
{"level":"info","ts":"2024-03-14T10:13:41Z","logger":"controller","msg":"Starting workers","controller":"nodeclaim.termination","controllerGroup":"karpenter.sh","controllerKind":"NodeClaim","worker count":100}
{"level":"info","ts":"2024-03-14T10:13:41Z","logger":"controller","msg":"Starting workers","controller":"nodeclaim.disruption","controllerGroup":"karpenter.sh","controllerKind":"NodeClaim","worker count":10}
{"level":"info","ts":"2024-03-14T10:13:42Z","logger":"controller","msg":"Starting workers","controller":"lease.garbagecollection","controllerGroup":"coordination.k8s.io","controllerKind":"Lease","worker count":10}
{"level":"info","ts":"2024-03-14T10:13:42Z","logger":"controller","msg":"Starting workers","controller":"state.daemonset","controllerGroup":"apps","controllerKind":"DaemonSet","worker count":10}

How was this change tested?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

fmuyassarov · 2024-02-28T11:25:21Z

/hold

fmuyassarov · 2024-02-28T11:27:17Z

ping @jonathan-innis

pkg/controllers/disruption/singlenodeconsolidation.go

pkg/utils/testing/util.go

coveralls · 2024-02-28T14:24:13Z

Pull Request Test Coverage Report for Build 9165359761

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

98 of 150 (65.33%) changed or added relevant lines in 46 files are covered.
3 unchanged lines in 2 files lost coverage.
Overall coverage increased (+0.1%) to 78.563%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
kwok/main.go	0	1	0.0%
pkg/controllers/disruption/helpers.go	3	4	75.0%
pkg/controllers/disruption/types.go	0	1	0.0%
pkg/controllers/provisioning/scheduling/scheduler.go	6	7	85.71%
pkg/controllers/disruption/multinodeconsolidation.go	1	3	33.33%
pkg/controllers/disruption/singlenodeconsolidation.go	1	3	33.33%
pkg/controllers/state/cluster.go	0	2	0.0%
pkg/controllers/provisioning/provisioner.go	11	14	78.57%
pkg/scheduling/volumeusage.go	0	3	0.0%
pkg/controllers/disruption/controller.go	2	6	33.33%

Files with Coverage Reduction	New Missed Lines	%
pkg/operator/logging/logging.go	1	0.0%
pkg/controllers/provisioning/scheduling/nodeclaim.go	2	89.01%

Totals
Change from base Build 9164948795:	0.1%
Covered Lines:	8275
Relevant Lines:	10533

💛 - Coveralls

pkg/controllers/nodeclaim/lifecycle/launch.go

Bryce-Soghigian · 2024-02-28T19:19:05Z

@fmuyassarov love this, can you include a run of with the kwok provider scale up and scale down of what these logs look like?

fmuyassarov · 2024-02-28T22:27:59Z

@fmuyassarov love this, can you include a run of with the kwok provider scale up and scale down of what these logs look like?

Absolutely. Will update soon after having results.

jonathan-innis

I didn't look at everything in detail yet, but have some high-level comments and thoughts about verbosity

go.mod

pkg/controllers/disruption/singlenodeconsolidation.go

pkg/utils/testing/util.go

pkg/controllers/disruption/controller.go

pkg/controllers/disruption/helpers.go

jonathan-innis · 2024-03-02T23:18:03Z

@Bryce-Soghigian Can comment more on the Azure provider, but the other thing to keep in mind here is that this change is going to cause the cloud providers to have to shift what logging package it's using as well, so we need to coordinate this change with a change in the cloud provider code so that cloud providers aren't blocked from upgrading to this newer version for too long.

@fmuyassarov Is this also something that you would be interested in taking up?

fmuyassarov · 2024-03-04T20:24:06Z

@Bryce-Soghigian Can comment more on the Azure provider, but the other thing to keep in mind here is that this change is going to cause the cloud providers to have to shift what logging package it's using as well, so we need to coordinate this change with a change in the cloud provider code so that cloud providers aren't blocked from upgrading to this newer version for too long.

@fmuyassarov Is this also something that you would be interested in taking up?

Sure, is there a common mailing list to broadcast the this change to the providers? I would expect community meeting is a good place to start but perhaps there are some other channels which I'm not aware of.

njtran

Really good work. Just have some comments on capitalization and nits.

pkg/controllers/disruption/controller.go

pkg/controllers/node/termination/terminator/eviction.go

pkg/controllers/nodeclaim/consistency/controller.go

pkg/controllers/nodeclaim/lifecycle/launch.go

pkg/controllers/provisioning/scheduling/scheduler.go

pkg/controllers/state/cluster.go

pkg/operator/controller/controller.go

pkg/operator/operator.go

pkg/scheduling/volumeusage.go

fmuyassarov · 2024-05-20T19:25:31Z

@njtran Thanks for the comments. I have addressed all of them except one. I can still fix it, but as I mentioned above I don't a strong preference there. PTAL.

Signed-off-by: Feruzjon Muyassarov <[email protected]>

njtran

/lgtm
/approve

Nice work!

k8s-ci-robot · 2024-05-20T19:48:57Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bryce-Soghigian, fmuyassarov, jonathan-innis, njtran

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [jonathan-innis,njtran]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

njtran · 2024-05-20T20:42:25Z

Actually, I see a reference to the knative logger here: https://github.com/kubernetes-sigs/karpenter/blob/main/kwok/main.go#L20 can you change this too?

kwok/main.go

jonathan-innis · 2024-05-21T00:03:56Z

@njtran gave it the go-ahead, so we're good to merge

jonathan-innis · 2024-05-21T00:04:11Z

/unhold

jonathan-innis · 2024-05-21T00:22:01Z

/lgtm

k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 28, 2024

k8s-ci-robot requested review from engedaam and tallaxes February 28, 2024 11:25

k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 28, 2024

fmuyassarov mentioned this pull request Feb 28, 2024

Migrate existing knative logger to controller-runtime injected logger #922

Closed

fmuyassarov commented Feb 28, 2024

View reviewed changes

pkg/controllers/disruption/singlenodeconsolidation.go Outdated Show resolved Hide resolved

pkg/utils/testing/util.go Outdated Show resolved Hide resolved

fmuyassarov force-pushed the devel/logging-migration branch 4 times, most recently from e9578fe to 9a6bd6a Compare February 28, 2024 14:06

fmuyassarov changed the title ~~WIP perf: migrate knative logger to controller-runtime injected logger~~ perf: migrate knative logger to controller-runtime injected logger Feb 28, 2024

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 28, 2024

Bryce-Soghigian reviewed Feb 28, 2024

View reviewed changes

pkg/controllers/nodeclaim/lifecycle/launch.go Outdated Show resolved Hide resolved

fmuyassarov force-pushed the devel/logging-migration branch from 9a6bd6a to da6e70d Compare February 28, 2024 22:29

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 1, 2024

jonathan-innis reviewed Mar 1, 2024

View reviewed changes

fmuyassarov force-pushed the devel/logging-migration branch from da6e70d to 16fa21c Compare March 1, 2024 17:43

k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 1, 2024

fmuyassarov force-pushed the devel/logging-migration branch from 16fa21c to ac0688e Compare March 1, 2024 17:47

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 2, 2024

jonathan-innis force-pushed the devel/logging-migration branch from c4b7d90 to 40d7cf0 Compare May 18, 2024 15:20

njtran reviewed May 20, 2024

View reviewed changes

fmuyassarov force-pushed the devel/logging-migration branch from 768cffd to 1c4a5ef Compare May 20, 2024 19:24

fmuyassarov requested a review from njtran May 20, 2024 19:25

Ensure consistent de-capitalization in logging messages

8c716ef

Signed-off-by: Feruzjon Muyassarov <[email protected]>

fmuyassarov force-pushed the devel/logging-migration branch from 1c4a5ef to 8c716ef Compare May 20, 2024 19:45

njtran reviewed May 20, 2024

View reviewed changes

k8s-ci-robot assigned njtran May 20, 2024

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 20, 2024

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 20, 2024

fmuyassarov commented May 20, 2024

View reviewed changes

kwok/main.go Outdated Show resolved Hide resolved

jonathan-innis force-pushed the devel/logging-migration branch 5 times, most recently from 772b8fa to b2091db Compare May 20, 2024 21:39

Fix capatilization and remove knative logger from kwok

172b06a

jonathan-innis force-pushed the devel/logging-migration branch from b2091db to 172b06a Compare May 20, 2024 21:39

jonathan-innis mentioned this pull request May 20, 2024

Migrate logger from knative to controller-runtime aws/karpenter-provider-aws#6150

Merged

3 tasks

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 21, 2024

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 21, 2024

k8s-ci-robot merged commit 9b145a6 into kubernetes-sigs:main May 21, 2024
12 checks passed

fmuyassarov deleted the devel/logging-migration branch May 21, 2024 06:26

jmdeal mentioned this pull request Jun 19, 2024

feat: disruption.terminationGracePeriod #916

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: migrate knative logger to controller-runtime injected logger #1050

chore: migrate knative logger to controller-runtime injected logger #1050

fmuyassarov commented Feb 28, 2024 •

edited

Loading

fmuyassarov commented Feb 28, 2024

fmuyassarov commented Feb 28, 2024

coveralls commented Feb 28, 2024 •

edited

Loading

Bryce-Soghigian commented Feb 28, 2024

fmuyassarov commented Feb 28, 2024 •

edited

Loading

jonathan-innis left a comment

jonathan-innis commented Mar 2, 2024

fmuyassarov commented Mar 4, 2024

njtran left a comment

fmuyassarov commented May 20, 2024

njtran left a comment

k8s-ci-robot commented May 20, 2024

njtran commented May 20, 2024

jonathan-innis commented May 21, 2024 •

edited

Loading

jonathan-innis commented May 21, 2024

jonathan-innis commented May 21, 2024

chore: migrate knative logger to controller-runtime injected logger #1050

chore: migrate knative logger to controller-runtime injected logger #1050

Conversation

fmuyassarov commented Feb 28, 2024 • edited Loading

fmuyassarov commented Feb 28, 2024

fmuyassarov commented Feb 28, 2024

coveralls commented Feb 28, 2024 • edited Loading

Pull Request Test Coverage Report for Build 9165359761

Warning: This coverage report may be inaccurate.

Details

💛 - Coveralls

Bryce-Soghigian commented Feb 28, 2024

fmuyassarov commented Feb 28, 2024 • edited Loading

jonathan-innis left a comment

Choose a reason for hiding this comment

jonathan-innis commented Mar 2, 2024

fmuyassarov commented Mar 4, 2024

njtran left a comment

Choose a reason for hiding this comment

fmuyassarov commented May 20, 2024

njtran left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented May 20, 2024

njtran commented May 20, 2024

jonathan-innis commented May 21, 2024 • edited Loading

jonathan-innis commented May 21, 2024

jonathan-innis commented May 21, 2024

fmuyassarov commented Feb 28, 2024 •

edited

Loading

coveralls commented Feb 28, 2024 •

edited

Loading

fmuyassarov commented Feb 28, 2024 •

edited

Loading

jonathan-innis commented May 21, 2024 •

edited

Loading