Bump kubernetes dependencies to v0.31.x. #670
Conversation
k8s-ci-robot
added
kind/cleanup
✅ Deploy Preview for kubernetes-sigs-jobset ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
k8s-ci-robot
added
the
size/XL
| @@ -289,7 +289,7 @@ artifacts: kustomize | |||
| GOLANGCI_LINT = $(PROJECT_DIR)/bin/golangci-lint | |||
| .PHONY: golangci-lint | |||
| golangci-lint: ## Download golangci-lint locally if necessary. | |||
| @GOBIN=$(PROJECT_DIR)/bin GO111MODULE=on $(GO_CMD) install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.52.2 | |||
| @GOBIN=$(PROJECT_DIR)/bin GO111MODULE=on $(GO_CMD) install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.60.3 | |||
There was a problem hiding this comment.
These changes are necessary because I encountered an error with the previous version:
ERRO [linters_context/goanalysis] fact_purity: panic during analysis: interface conversion: interface {} is nil, not *buildir.IR, goroutine 8676 [running]:
runtime/debug.Stack()
| # Settings related to issues | ||
| issues: | ||
| # Which dirs to exclude: issues from them won't be reported | ||
| exclude-dirs: |
There was a problem hiding this comment.
This is need because I have a warning after lint upgrade:
WARN [config_reader] The configuration option `run.skip-dirs` is deprecated, please use `issues.exclude-dirs`.
|
/lgtm Thanks a lot for fixing this! |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahg-g, mbobrovskyi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
| @@ -124,7 +124,7 @@ ci-lint: golangci-lint | |||
| $(GOLANGCI_LINT) run --timeout 15m0s | |||
|
|
|||
| .PHONY: test | |||
| test: manifests fmt vet envtest gotestsum test-python-sdk | |||
There was a problem hiding this comment.
Quick question on this, why did you remove test-python-sdk from the test Make command?
There was a problem hiding this comment.
Uhm... It seems it was accidental. I will undo this change. Thanks!
There was a problem hiding this comment.
Reverted on #673.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Bump kubernetes dependencies to v0.31.x.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Related to #662 (comment).
Does this PR introduce a user-facing change?