Update readme with new failure policy details #659
Conversation
✅ Deploy Preview for kubernetes-sigs-jobset ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
danielvegamyhre
force-pushed
the
readme2
branch
from
177b6aa
to
2577eb0
Compare
|
Unknown CLA label state. Rechecking for CLA labels. Send feedback to sig-contributor-experience at kubernetes/community. /check-cla |
k8s-ci-robot
added
the
cncf-cla: yes
|
/retest |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danielvegamyhre The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
| @@ -21,8 +21,6 @@ Take a look at the [concepts](https://jobset.sigs.k8s.io/docs/concepts/) page fo | |||
|
|
|||
| - **Configurable success policies**: JobSet has [configurable success policies](https://github.com/kubernetes-sigs/jobset/blob/v0.6.0/examples/simple/success-policy.yaml) which target specific ReplicatedJobs, with operators to target `Any` or `All` of their child jobs. For example, you can configure the JobSet to be marked complete if and only if all pods that are part of the “worker” ReplicatedJob are completed. This enables users to use their compute resources more efficiently, allowing a workload to be declared successful and release the resources for the next workload more quickly. | |||
|
|
|||
| - **Configurable failure policies**: JobSet has [configurable failure policies](https://github.com/kubernetes-sigs/jobset/blob/v0.6.0/examples/simple/max-restarts.yaml) which allow the user to specify a maximum number of times the JobSet should be restarted in the event of a failure. If any job is marked failed, the entire JobSet will be recreated, allowing the workload to resume from the last checkpoint. When no failure policy is specified, if any job fails, the JobSet simply fails. | |||
There was a problem hiding this comment.
I'm a little curious. We only delete the old description. Do we also need to update it to the new description?
There was a problem hiding this comment.
What the... something weird is going on with the CI, last night the diff was correct and now it's missing the new content... let me try to fix it
There was a problem hiding this comment.
This is so weird, my local commit 2577eb0 has the correct changes, and supposedly has been pushed to remote origin:
danielvm@danielvm622:~/go/src/sigs.k8s.io/jobset$ git push origin readme2
Everything up-to-date
Yet the diff here does not include the changes.
Part of #655