Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release-0.5] Do not default the managedBy field #533

Conversation

kannon92
Copy link
Contributor

Cherry pick this into release-0.5.

This is to keep the same behavior as upstream Job and to support Kueue use case. This was a major point of release 0.5 so I think a cherry-pick is useful.

We also need #527 in the patch so we should not release a patch until that PR is also in the release.

@k8s-ci-robot k8s-ci-robot requested a review from ahg-g April 19, 2024 13:47
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 19, 2024
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 19, 2024
@kannon92 kannon92 changed the title Do not default the managedBy field [Release-0.5] Do not default the managedBy field Apr 19, 2024
@kannon92
Copy link
Contributor Author

/cc @mimowo

@mimowo
Copy link
Contributor

mimowo commented Apr 19, 2024

LGTM

@kannon92
Copy link
Contributor Author

/assign @danielvegamyhre @ahg-g

This and the other managedBy change should probably be released for 0.5.1.

@danielvegamyhre
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danielvegamyhre, kannon92

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 19, 2024
@danielvegamyhre
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 20, 2024
@k8s-ci-robot k8s-ci-robot merged commit cb44e54 into kubernetes-sigs:release-0.5 Apr 20, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants