-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add event recorder event #507
feat: add event recorder event #507
Conversation
Hi @googs1025. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
✅ Deploy Preview for kubernetes-sigs-jobset canceled.
|
cdb1192
to
0d917ce
Compare
/ok-to-test Not sure if we necessarily need to emit an event for this. What are your thoughts @kannon92? |
Signed-off-by: googs1025 <[email protected]>
0d917ce
to
c4a202a
Compare
What is the behavior if the service creation fails? I think it would be an error in the jobset controller logs which is not the best UX. And someone would have to know that a service was created. Events are a better user experience than logs of the controller. |
True. Alright let's include this change |
/lgtm |
/approve Thanks! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danielvegamyhre, googs1025 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
refer to: #506