Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add event recorder event #507

Merged
merged 2 commits into from
Apr 18, 2024

Conversation

googs1025
Copy link
Member

@googs1025 googs1025 commented Apr 12, 2024

refer to: #506

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 12, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @googs1025. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 12, 2024
Copy link

netlify bot commented Apr 12, 2024

Deploy Preview for kubernetes-sigs-jobset canceled.

Name Link
🔨 Latest commit 608f29b
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-jobset/deploys/662071636b9de20008a874f6

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 13, 2024
@danielvegamyhre
Copy link
Contributor

/ok-to-test

Not sure if we necessarily need to emit an event for this. What are your thoughts @kannon92?

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 15, 2024
@kannon92
Copy link
Contributor

/ok-to-test

Not sure if we necessarily need to emit an event for this. What are your thoughts @kannon92?

What is the behavior if the service creation fails? I think it would be an error in the jobset controller logs which is not the best UX. And someone would have to know that a service was created.

Events are a better user experience than logs of the controller.

@danielvegamyhre
Copy link
Contributor

/ok-to-test
Not sure if we necessarily need to emit an event for this. What are your thoughts @kannon92?

What is the behavior if the service creation fails? I think it would be an error in the jobset controller logs which is not the best UX. And someone would have to know that a service was created.

Events are a better user experience than logs of the controller.

True. Alright let's include this change

@kannon92
Copy link
Contributor

/lgtm
/assign @danielvegamyhre

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 18, 2024
@danielvegamyhre
Copy link
Contributor

/approve

Thanks!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danielvegamyhre, googs1025

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 18, 2024
@k8s-ci-robot k8s-ci-robot merged commit 9dc4358 into kubernetes-sigs:main Apr 18, 2024
12 checks passed
@danielvegamyhre danielvegamyhre mentioned this pull request Aug 19, 2024
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants