Skip to content

Commit

Permalink
Remove GO_VERSION test matrix
Browse files Browse the repository at this point in the history
We'll have to keep go version in go.mod at the latest, to ensure golang
compatibility support throughout the release lifetime. However this breaks
buildability with older golang images, since Go 1.21.
  • Loading branch information
jingyuanliang committed Feb 7, 2024
1 parent a311e53 commit 97637fd
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
3 changes: 1 addition & 2 deletions .github/workflows/crossbuild.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,10 @@ jobs:
crossbuild:
strategy:
matrix:
go-version: [ "1.20", "1.21", "1.22" ]
platform: [ "ubuntu-latest" ]
runs-on: ${{ matrix.platform }}
steps:
- name: Checkout code
uses: actions/checkout@v3
- name: Build containers
run: make all-container GO_VERSION=${{ matrix.go-version }}
run: make all-container
3 changes: 1 addition & 2 deletions .github/workflows/tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,10 @@ jobs:
test:
strategy:
matrix:
go-version: [ "1.21", "1.22" ]
platform: [ "ubuntu-latest" ]
runs-on: ${{ matrix.platform }}
steps:
- name: Checkout code
uses: actions/checkout@v3
- name: Test
run: make test GOFLAGS="-v" GO_VERSION=${{ matrix.go-version }}
run: make test GOFLAGS="-v"

0 comments on commit 97637fd

Please sign in to comment.