Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable ipv6 forwarding on instances #97

Merged
merged 1 commit into from
Feb 19, 2020

Conversation

aojea
Copy link
Contributor

@aojea aojea commented Nov 11, 2019

We need to enable ipv6 forwarding on instance in order to support ipv6 k8s clusters.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 11, 2019
@aojea
Copy link
Contributor Author

aojea commented Nov 11, 2019

/assign @detiber
/cc @dims

@aojea aojea changed the title enable ipv6 forwarding on instances WIP enable ipv6 forwarding on instances Nov 11, 2019
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 11, 2019
@aojea
Copy link
Contributor Author

aojea commented Nov 11, 2019

I want to check first if something else is missing
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 11, 2019
@dims
Copy link
Member

dims commented Nov 14, 2019

@aojea how's this going? need some help?

@aojea
Copy link
Contributor Author

aojea commented Nov 14, 2019

@aojea how's this going? need some help?

I'm able to deploy the network infra with my PR to the cluster-api-provider-aws, but I'm trying to fix the panics with the conversions.

Although the subnets and VPC are created, I can't progress because I can't use the cloudformation template in my account :/ , need to check if I can get some way to overcome that.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 12, 2020
@detiber
Copy link
Member

detiber commented Feb 12, 2020

/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 12, 2020
Also ensure that IPv6 is enabled.

This is required for dual-stack and IPv6 clusters.
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 15, 2020
@aojea aojea changed the title WIP enable ipv6 forwarding on instances enable ipv6 forwarding on instances Feb 15, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 15, 2020
@aojea
Copy link
Contributor Author

aojea commented Feb 15, 2020

/hold cancel
I've documented how to deploy k8s ipv6 clusters in AWS here (still missing the aws-cloud-provider integration) https://github.com/aojea/k8s-aws-ipv6

we need to enable this kernel parameters to be able to use these images
@justinsb @dims @detiber @andrewsykim

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 15, 2020
@dims
Copy link
Member

dims commented Feb 15, 2020

cc @jayunit100 @sedefsavas

@dims
Copy link
Member

dims commented Feb 15, 2020

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 15, 2020
@aojea
Copy link
Contributor Author

aojea commented Feb 18, 2020

/assign @detiber

@detiber
Copy link
Member

detiber commented Feb 19, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, detiber, dims

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 19, 2020
@k8s-ci-robot k8s-ci-robot merged commit efb6f94 into kubernetes-sigs:master Feb 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants