upgrade pip to fix azure-cli installation flakes #958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
size/XS
k8s-ci-robot
added
approved
|
/test pull-azure-vhds |
|
/assign @jsturtevant @CecileRobertMichon |
|
lgtm /assign @mboersma |
mboersma
approved these changes
Aug 25, 2022
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kkeshavamurthy, mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was referenced Aug 25, 2022
jkoelker
added a commit
to mesosphere/konvoy-image-builder
that referenced
this pull request
Aug 29, 2022
Port upstreaam change: kubernetes-sigs/image-builder#958
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fixes #766
Upgrading pip seems to be have fixed the azure-cli installation issues in my testing.
I'm upgrading it to latest on both 18.04 & 20.04. Let me know if I should restrict it to just 18.04.