Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

containerd: update to v1.6.1 #822

Conversation

seanschneeweiss
Copy link
Contributor

@seanschneeweiss seanschneeweiss commented Mar 9, 2022

What this PR does / why we need it:

Updates containerd to 1.6.1.

Release Notes: https://github.com/containerd/containerd/releases/tag/v1.6.1

Which issue(s) this PR fixes (optional, in fixes #(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):

Additional context
Sean Schneeweiss [email protected], Daimler TSS GmbH, Provider Information

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 9, 2022
@seanschneeweiss
Copy link
Contributor Author

seanschneeweiss commented Mar 9, 2022

pull-azure-vhds failed

vhd-ubuntu-1804: TASK [providers : install Azure clients]
vhd-ubuntu-1804: fatal: [default]: FAILED! => {"changed": false, "cmd": ["/usr/bin/pip3", "install", "azure-cli"]
...
ModuleNotFoundError: No module named 'setuptools_rust'

@seanschneeweiss
Copy link
Contributor Author

Looks like the error is related to #766.
/retest

@codenrhoden
Copy link
Contributor

@seanschneeweiss any idea what's happening with the Assets in this containerd release? It looks like all the assets on the GitHub release page are duplicated, and they have different sizes, so I can't tell which is the right one (or which one is the right checksum to validate).

@seanschneeweiss
Copy link
Contributor Author

seanschneeweiss commented Mar 10, 2022

For Windows the following is used:

"containerd_url": "https://github.com/containerd/containerd/releases/download/v{{user `containerd_version`}}/containerd-{{user `containerd_version`}}-windows-amd64.tar.gz"

And for Linux, e.g. QEMU build:

"containerd_url": "https://github.com/containerd/containerd/releases/download/v{{user `containerd_version`}}/cri-containerd-cni-{{user `containerd_version`}}-linux-amd64.tar.gz",

The others as DigitalOcean etc. use the same URL.

@codenrhoden
Copy link
Contributor

I see what I did now. I'm still not used to seeing arm64 assets, which showed up as new with 1.6.0. I saw "arm64" and my brain changed it to "amd64". That's why I thought there were two of each. I wasn't confused at the image-builder side of things, I just had thought there were duplicate files at https://github.com/containerd/containerd/releases/tag/v1.6.1 (which I wouldn't have thought possible -- and indeed it is not the case). Thanks. Will take a closer look now.

@codenrhoden
Copy link
Contributor

/lgtm
/approve

Thank you!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: codenrhoden, seanschneeweiss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 10, 2022
@k8s-ci-robot k8s-ci-robot merged commit 4577f24 into kubernetes-sigs:master Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants