-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use nssm for kubelet log rotation on Windows #762
Use nssm for kubelet log rotation on Windows #762
Conversation
/sig windows |
f0319c0
to
ec4c801
Compare
ec4c801
to
cb63449
Compare
cb63449
to
98e1e61
Compare
hmm the pip install failed here too, we may need an updated pip in ci?
/retest |
failure was ubuntu:
Windows passed: /retest |
flake with prow reading the Azure secrets /retest |
packer crashed:
I don't see anything in this pr that would cause this will run again then investigate if it happens again... /retest |
created issue for Ubuntu pip error: #766 /retest |
ah this looks much better, ive want to have that auto for a while but the logs always stopped me, thank @jsturtevant /lgtm |
application: '%SystemRoot%\System32\WindowsPowerShell\v1.0\powershell.exe' | ||
arguments: '-ExecutionPolicy Bypass -NoProfile {{ kubernetes_install_path }}\StartKubelet.ps1' | ||
app_rotate_bytes: 10485760 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this be configurable and defaulted to this value if not passed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can improve it on another PR..
/lgtm |
/assign @codenrhoden @CecileRobertMichon |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon, jsturtevant The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
When installing kubelet via nssm we still used kubelets built in logging. The built in logger logs duplicated data two three different files streams which isn't useful since it duplicates data and the error/warning files don't have enough context in them.
Since we already use nssm we can use the built in log redirection and logging will be much simpler to reason about and contain less information. The log files will still be in the same location.
This also turns on kubelet to Automatic so it will boot automatically on restart (#554)
Which issue(s) this PR fixes (optional, in fixes #(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #554
Additional context
Add any other context for the reviewers