-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set feature flag for Cloud Init 21.2-69-g65607405-0ubuntu1 for Ubuntu systems for compatibility with Cluster API Provider AWS #406
Conversation
for compatibility with Cluster API Provider AWS Signed-off-by: Naadir Jeewa <[email protected]>
/lgtm |
/assign @ncdc |
@randomvariable from reading the cloud-init change, it sounds like this feature flag will be removed and the updated error handling will be the only option once cloud-init stops support Focal (20.04). Do we need to worry about that upcoming change, or is it more likely we'll have an updated method for secure bootstrap data before that happens? /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ncdc, randomvariable, voor The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@ncdc The CAEP that will emerge out of kubernetes-sigs/cluster-api#3761 should deal with that. I hope we get around to it before 2025! |
Due to kubernetes-sigs/image-builder#406, have had to rebuild Ubuntu AMIs. Am also bumping e2e versions so we have signal. Signed-off-by: Naadir Jeewa <[email protected]>
Validated this now runs cloud-init as expected on Ubuntu 18.04 builds successfully. |
This mechanism for overriding features was recently removed in cloud-init, and is in the latest cloud-init release of Ubuntu 20.04. To build working CAPA Ubuntu 20.04 images, we have to downgrade cloud-init. See #1333 We need to revisit this in order to support Ubuntu 20.04 and newer versions with CAPA. |
Latest version of cloud-init "improves" error handling. Unfortunately, this breaks what we're using to download encrypted user data in Cluster API Provider AWS.
This re-enables the old behaviour by setting the appropriate feature flag.
The CentOS & Fedora derivative operating systems are using a much older version of cloud-init.