allow kubeadm image repo customization #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
size/L
allow kubeadm image repo customization and allow kubernetes rpm and deb versions follow different convention Signed-off-by: Hui Luo <[email protected]>
|
@jiatongw: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: akutz, figo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
Signed-off-by: Hui Luo <[email protected]>
detiber
reviewed
Aug 27, 2019
k8s-ci-robot
removed
the
lgtm
cleanup the kubeadm config after been used. Signed-off-by: Hui Luo <[email protected]>
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/lgtm |
k8s-ci-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a few changes included in this PR:
then
ansible/filter_plugins/kube.pyno longer neededkubernetes_source_type, the value either bepkg(rpm/deb) orhttp, which define where kubeadm, kubelet, kubectl comes from, the same goes tokubernetes_cni_source_typeSigned-off-by: Hui Luo [email protected]
cc @detiber @jiatongw