Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dependabot to image builder repo #1535

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

nawazkh
Copy link
Member

@nawazkh nawazkh commented Aug 8, 2024

Change description

  • This PR adds dependabot to image-builder repo.

Related issues

Additional context

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 8, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign mboersma for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 8, 2024
@nawazkh
Copy link
Member Author

nawazkh commented Aug 8, 2024

Not sure if I am missing any context on why dependabot was not added to this repo, so creating this PR to add it.

@nawazkh
Copy link
Member Author

nawazkh commented Aug 8, 2024

/cc @mboersma @jsturtevant @jackfrancis

@AverageMarcus
Copy link
Member

There's some background context in this issue: #1283

Could you please include examples of what updates dependabot will generate for us? What versions will be covered, what wont?

@nawazkh
Copy link
Member Author

nawazkh commented Aug 8, 2024

Thank you for sharing the context @AverageMarcus. It is an interesting challenge to update various hardcoded semver-versions along with dependabot version updates.

I have an idea, not sure how viable, but here it is: (I will mark this PR draft to avoid notification churn)

  • Configure dependabot to update versions in package-manager. In our case, say Dependabot updates a dependency in Dockerfile.
  • Have a script that scans all the dirs for below files and find dependencies variables, replace them with latest version in the same Dependabot's PR(this can be achieved using GitHub actions).
    • *.json
    • .hcl
    • *.sh

Marking this PR WIP and push changes soon. Thanks!

@nawazkh nawazkh marked this pull request as draft August 8, 2024 20:06
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 8, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants