Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Windows 23H2 Datacenter offering as Windows Annual Channel for Azure #1528

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

nawazkh
Copy link
Member

@nawazkh nawazkh commented Jul 27, 2024

Change description

Related issues

  • Fixes #

Additional context

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 27, 2024
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 27, 2024
@nawazkh nawazkh force-pushed the update_win_vhds branch 2 times, most recently from 1327b78 to ddf4c80 Compare July 29, 2024 21:26
images/capi/Makefile Outdated Show resolved Hide resolved
images/capi/Makefile Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 29, 2024
"image_offer": "WindowsServer",
"image_publisher": "MicrosoftWindowsServer",
"image_sku": "23h2-datacenter-core",
"image_version": "latest",
"load_additional_components": "false",
"runtime": "containerd",
"shared_image_gallery_name": "{{env `GALLERY_NAME`}}",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to keep the below hack?

"source_sig_image_name": "{{env `SOURCE_SIG_IMAGE_NAME`}}",
  "source_sig_image_version": "{{env `SOURCE_SIG_IMAGE_VERSION`}}",
  "source_sig_name": "{{env `SOURCE_SIG_NAME`}}",
  "source_sig_resource_group_name": "{{env `SOURCE_SIG_RESOURCE_GROUP`}}",
  "source_sig_subscription_id": "{{env `SOURCE_SIG_SUB_ID`}}",

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, we don't need this as we will publish this image to the marketplace

@jsturtevant
Copy link
Contributor

sorry for the confusion, We want both sig and vhd versions of the make command, the latest updates look right for the sig, but will need to also add the vhd command to the make file

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 29, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign mboersma for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nawazkh nawazkh changed the title Add Windows 23H2 Datacenter Channel target for Azure Add Windows 23H2 Datacenter offering as Windows Annual Channel for Azure Jul 29, 2024
@nawazkh nawazkh marked this pull request as ready for review July 29, 2024 23:18
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 29, 2024
@nawazkh
Copy link
Member Author

nawazkh commented Aug 5, 2024

/retest

- update packer/azure/, makefile
- reuse annual channel for win offering
- remove sig information from the container json
- update vhd and sig lists
@nawazkh nawazkh marked this pull request as draft August 5, 2024 22:12
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 5, 2024
@nawazkh
Copy link
Member Author

nawazkh commented Aug 6, 2024

/retest

Copy link

CLA Missing ID CLA Not Signed

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. and removed cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 6, 2024
@nawazkh nawazkh marked this pull request as ready for review August 6, 2024 17:39
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 6, 2024
@nawazkh
Copy link
Member Author

nawazkh commented Aug 8, 2024

CLA Missing ID CLA Not Signed

Pushed commit from my dev VM, will squash and push from local machine.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 5, 2024
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link
Contributor

@nawazkh: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-azure-vhds 2133491 link true /test pull-azure-vhds
pull-ova-all 2133491 link false /test pull-ova-all
pull-azure-sigs 2133491 link false /test pull-azure-sigs
pull-gcp-all 2133491 link true /test pull-gcp-all

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants