-
Notifications
You must be signed in to change notification settings - Fork 395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ansible actions use fully-qualified collection names #1404
Ansible actions use fully-qualified collection names #1404
Conversation
Welcome @jongwooo! |
Hi @jongwooo. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sorry it took me so long to get back to this @jongwooo. I think I found all the places the linter removed comments or whitespace.
Hopefully you can make these changes and rebase the PR--I know it's huge and kind of tricky. Please let us know if you have any questions or need a hand.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thanks again for this! It looks good to me, but it's huge so let's have another maintainer take a look before we merge it.
/assign @AverageMarcus @drew-viles
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As best as I can tell this looks good. I haven't checked every single command is referencing the correct full name though but I trust that it's all correct. 😄
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AverageMarcus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Change description
Use fully-qualified collection name of all ansible actions.
AS-IS
win_firewall_rule:
TO-BE
community.windows.win_firewall_rule:
/cc @mboersma @AverageMarcus
Related issues
Additional context
None