Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module name changed to sigs.k8s.io/ibm-powervs-block-csi-driver #72

Closed
wants to merge 2 commits into from

Conversation

Madhan-SWE
Copy link

@Madhan-SWE Madhan-SWE commented Jan 4, 2022

  • Module name changed to sigs.k8s.io/ibm-powervs-block-csi-driver
  • Internal names changed from powervs-csi-driver to ibm-powervs-block-csi-driver

Other fix in Makefile :

  • The Version for the image was hardcoded as latest earlier. Now changed as per variable VERSION

@ppc64le-cloud-bot ppc64le-cloud-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 4, 2022
Copy link
Member

@mkumatag mkumatag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@ppc64le-cloud-bot ppc64le-cloud-bot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 4, 2022
@mkumatag
Copy link
Member

mkumatag commented Jan 4, 2022

@Madhan-SWE please change the repo name in the github as well.

@Madhan-SWE
Copy link
Author

@mkumatag repo name changed

@mkumatag
Copy link
Member

mkumatag commented Jan 4, 2022

@Rajalakshmi-Girish can you check why PR is not merging even after having lgtm and approval tags

@Rajalakshmi-Girish
Copy link
Contributor

@Rajalakshmi-Girish can you check why PR is not merging even after having lgtm and approval tags

I see below error in tide log:

{"base-sha":"0dc89b554512c7f549c108198c426ff65995472e","branch":"main","component":"tide","controller":"sync","error":"status code 404 not one of [200 405 409], body: {\"message\":\"Not Found\",\"documentation_url\":\https://docs.github.com/rest/reference/pulls#merge-a-pull-request\}","file":"prow/tide/tide.go:1247","func":"k8s.io/test-infra/prow/tide.(*Controller).mergePRs","level":"debug","merge-targets":[72],"msg":"Merge failed.","org":"ppc64le-cloud","pr":72,"repo":"ibm-powervs-block-csi-driver","severity":"debug","sha":"666be324fcd0816dd05983c2210e7527811dfd68","time":"2022-01-04T09:29:58Z"}

404 might be due to change of org name from powervs-csi-driver to ibm-powervs-block-csi-driver while the PR review is in progress..
@mkumatag Can we try re-creating a new PR and check?

@mkumatag mkumatag closed this Jan 4, 2022
@mkumatag mkumatag reopened this Jan 4, 2022
@mkumatag
Copy link
Member

mkumatag commented Jan 4, 2022

/meow

@ppc64le-cloud-bot
Copy link

@mkumatag: cat image

In response to this:

/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mkumatag
Copy link
Member

mkumatag commented Jan 4, 2022

/approve

@mkumatag mkumatag closed this Jan 4, 2022
@mkumatag mkumatag reopened this Jan 4, 2022
@ppc64le-cloud-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Madhan-SWE, mkumatag

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mkumatag
Copy link
Member

mkumatag commented Jan 4, 2022

@Madhan-SWE can you please resolve the conflicts?

@ppc64le-cloud-bot ppc64le-cloud-bot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 5, 2022
@ppc64le-cloud-bot
Copy link

New changes are detected. LGTM label has been removed.

@ppc64le-cloud-bot
Copy link

@Madhan-SWE: Adding label do-not-merge/contains-merge-commits because PR contains merge commits, which are not allowed in this repository.
Use git rebase to reapply your commits on top of the target branch. Detailed instructions for doing so can be found here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Madhan-SWE
Copy link
Author

Resolving conflicts from UI creates merge commits and that leads to do-not-merge label addition.
Created a new PR with proper rebase: #75

@mkumatag
Copy link
Member

mkumatag commented Jan 5, 2022

merged via #75 , hence can be closed
/close

@ppc64le-cloud-bot
Copy link

@mkumatag: Closed this PR.

In response to this:

merged via #75 , hence can be closed
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

yussufsh pushed a commit to yussufsh/ibm-powervs-block-csi-driver that referenced this pull request Jan 30, 2024
…/cherry-pick-69-to-release-4.14

[release-4.14] OCPBUGS-25980: Rebase with upstream: Fix snyk code issue: Path Traversal
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/contains-merge-commits size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants