Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

examples added #53

Merged
merged 3 commits into from
Dec 16, 2021
Merged

examples added #53

merged 3 commits into from
Dec 16, 2021

Conversation

Madhan-SWE
Copy link

Fixes: #18

@ppc64le-cloud-bot ppc64le-cloud-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 13, 2021
mkumatag
mkumatag requested changes Dec 16, 2021
View reviewed changes
Copy link
Member

@mkumatag mkumatag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with all the additional examples, do we still need to examples in the below dir:

examples/pvc.yaml
examples/pod.yaml
examples/sc.yaml

examples/kubernetes/block-volume/specs/pod.yaml Outdated
volumes:
- name: data
persistentVolumeClaim:
claimName: block-claim
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add the new line in the end and in all the files wherever required

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@Madhan-SWE
Copy link
Author

with all the additional examples, do we still need to examples in the below dir:

examples/pvc.yaml
examples/pod.yaml
examples/sc.yaml

files removed

mkumatag
mkumatag approved these changes Dec 16, 2021
View reviewed changes
Copy link
Member

@mkumatag mkumatag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ppc64le-cloud-bot ppc64le-cloud-bot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 16, 2021
@ppc64le-cloud-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Madhan-SWE, mkumatag

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ppc64le-cloud-bot ppc64le-cloud-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 16, 2021
@ppc64le-cloud-bot ppc64le-cloud-bot merged commit 25772d4 into kubernetes-sigs:main Dec 16, 2021
@Madhan-SWE Madhan-SWE mentioned this pull request Feb 18, 2022
Closed
9 tasks
kishen-v pushed a commit to kishen-v/ibm-powervs-block-csi-driver that referenced this pull request Jun 17, 2024
@openshift-ci
Merge pull request kubernetes-sigs#53 from jaypoulz/bump-network-4.12
dda4b0d 
OCPBUGS-21079: CVE-2023-39325 - Update net dependencies - 4.12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkumatag mkumatag mkumatag approved these changes

Assignees

@mkumatag mkumatag

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add examples
4 participants
@Madhan-SWE @ppc64le-cloud-bot @mkumatag @rcmadhankumar