Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scanning scsi bus removed as it sometimes stuck in the middle #45

Merged
merged 1 commit into from
Dec 16, 2021
Merged

Scanning scsi bus removed as it sometimes stuck in the middle #45

merged 1 commit into from
Dec 16, 2021

Conversation

Madhan-SWE
Copy link

Fixes: #19

@ppc64le-cloud-bot ppc64le-cloud-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 10, 2021
@mkumatag
Copy link
Member

This code is derived from here: https://github.com/kubernetes-csi/csi-lib-fc, maybe we should start using that module and avoid making any changes here.

@Madhan-SWE
Copy link
Author

This code is derived from here: https://github.com/kubernetes-csi/csi-lib-fc, maybe we should start using that module and avoid making any changes here.

Yes Correct.
I will make necessary changes.

@ppc64le-cloud-bot ppc64le-cloud-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 10, 2021
mkumatag
mkumatag requested changes Dec 10, 2021
View reviewed changes
Copy link
Member

@mkumatag mkumatag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sure to compare with the upstream code and see whats the difference is in this file?! and also run good amount of tests to confirm this is working fine.

pkg/util/util.go Outdated
@@ -92,3 +94,13 @@ func GetAccessModes(caps []*csi.VolumeCapability) *[]string {
}
return &modes
}

func RemoveMultipathDevice(device string) error {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should aim to push this code to https://github.com/kubernetes-csi/csi-lib-fc

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Raised: kubernetes-retired/csi-lib-fc#4

mkumatag
mkumatag approved these changes Dec 16, 2021
View reviewed changes
Copy link
Member

@mkumatag mkumatag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be merged now, later whenever we merge the upstream code then we can replace with that.

/lgtm
/hold

added hold as well, remove the hold whenever you are comfortable.

@ppc64le-cloud-bot ppc64le-cloud-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 16, 2021
@ppc64le-cloud-bot ppc64le-cloud-bot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 16, 2021
@mkumatag
Copy link
Member

@Madhan-SWE I see conflicts here as well, the following instructions can help you rebase your code.

git remote add upstream https://github.com/ppc64le-cloud/powervs-csi-driver.git
git fetch upstream
git checkout main
git merge upstream/main
git checkout host_scan_optimization
git merge origin/main

and also fix the build error

@Madhan-SWE Madhan-SWE force-pushed the host_scan_optimization branch from e4f1692 to 27617a1 Compare December 16, 2021 06:12
@ppc64le-cloud-bot ppc64le-cloud-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 16, 2021
@Madhan-SWE Madhan-SWE force-pushed the host_scan_optimization branch from 1b175c4 to 18f4430 Compare December 16, 2021 06:15
@Madhan-SWE Madhan-SWE mentioned this pull request Dec 16, 2021
Closed
@Madhan-SWE
Copy link
Author

Madhan-SWE commented Dec 16, 2021 •
edited
Loading

Raised separate issue to use upstream fibre channel.
reference: #60
This PR can be released and merged.

@Madhan-SWE Madhan-SWE removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 16, 2021
mkumatag
mkumatag approved these changes Dec 16, 2021
View reviewed changes
Copy link
Member

@mkumatag mkumatag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ppc64le-cloud-bot ppc64le-cloud-bot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 16, 2021
@ppc64le-cloud-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Madhan-SWE, mkumatag

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ppc64le-cloud-bot ppc64le-cloud-bot merged commit aa7a5f7 into kubernetes-sigs:main Dec 16, 2021
@Madhan-SWE Madhan-SWE mentioned this pull request Feb 18, 2022
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkumatag mkumatag mkumatag approved these changes

Assignees

@mkumatag mkumatag

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Optimize the CSI code for rescanning the device
4 participants
@Madhan-SWE @mkumatag @ppc64le-cloud-bot @rcmadhankumar