Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GET_VOLUME_STATS node capability added #110

Merged

Conversation

dharaneeshvrd
Copy link
Contributor

What type of PR is this?
/kind feature

What this PR does / why we need it:
Implemented NodeGetVolumeStats

Which issue(s) this PR fixes:

Fixes #37

Special notes for your reviewer:

Release note:

none

@ppc64le-cloud-bot ppc64le-cloud-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 27, 2022
@ppc64le-cloud-bot ppc64le-cloud-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 27, 2022
pkg/driver/node.go Outdated Show resolved Hide resolved
Copy link

@Madhan-SWE Madhan-SWE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial review

@Madhan-SWE
Copy link

@mkumatag I have added my comments.
See if you need any other changes.

@Madhan-SWE
Copy link

/lgtm
/approve

@ppc64le-cloud-bot ppc64le-cloud-bot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 28, 2022
@ppc64le-cloud-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dharaneeshvrd, Madhan-SWE

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ppc64le-cloud-bot ppc64le-cloud-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 28, 2022
@ppc64le-cloud-bot ppc64le-cloud-bot merged commit 24a1494 into kubernetes-sigs:main Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Node GetVolume stats implementation for node plugin
3 participants