-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resource config removed log continues to be output #251
Resource config removed log continues to be output #251
Conversation
Hi @mochizuki875. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @adrianludwin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
/lgtm
/approve
Thanks for this change!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adrianludwin, mochizuki875 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Once the HNC configuration is configured to propagate any resource and the propagation configuration is removed, resource config removed log continues to be output like this.
This log is output in
hncconfig.reconcile
every 10s by default.I think these logs are needed for developers, but noisy and unnecessary for users.
So I changed the log level in this PR.