Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resource config removed log continues to be output #251

Merged
merged 1 commit into from
Feb 10, 2023

Conversation

mochizuki875
Copy link
Member

Once the HNC configuration is configured to propagate any resource and the propagation configuration is removed, resource config removed log continues to be output like this.
This log is output in hncconfig.reconcile every 10s by default.

$ kubectl hns config set-resource secrets --mode Propagate
$ kubectl hns config delete-type --resource secrets

$ kubectl -n hnc-system logs hnc-controller-manager-xxx-xxx -f
...
{"level":"info","ts":1674442998.959223,"logger":"hncconfig.reconcile","msg":"Resource config removed, will no longer update objects","gvk":"/v1, Kind=Secret"}
{"level":"info","ts":1674443008.9598093,"logger":"hncconfig.reconcile","msg":"Resource config removed, will no longer update objects","gvk":"/v1, Kind=Secret"}
{"level":"info","ts":1674443018.9604442,"logger":"hncconfig.reconcile","msg":"Resource config removed, will no longer update objects","gvk":"/v1, Kind=Secret"}
{"level":"info","ts":1674443028.961003,"logger":"hncconfig.reconcile","msg":"Resource config removed, will no longer update objects","gvk":"/v1, Kind=Secret"}
{"level":"info","ts":1674443038.9610357,"logger":"hncconfig.reconcile","msg":"Resource config removed, will no longer update objects","gvk":"/v1, Kind=Secret"}
{"level":"info","ts":1674443048.961513,"logger":"hncconfig.reconcile","msg":"Resource config removed, will no longer update objects","gvk":"/v1, Kind=Secret"}
{"level":"info","ts":1674443058.9616916,"logger":"hncconfig.reconcile","msg":"Resource config removed, will no longer update objects","gvk":"/v1, Kind=Secret"}
{"level":"info","ts":1674443068.9626572,"logger":"hncconfig.reconcile","msg":"Resource config removed, will no longer update objects","gvk":"/v1, Kind=Secret"}
...

I think these logs are needed for developers, but noisy and unnecessary for users.
So I changed the log level in this PR.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 30, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @mochizuki875. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 30, 2023
@mochizuki875 mochizuki875 deleted the change_log_level branch January 30, 2023 05:53
@mochizuki875 mochizuki875 restored the change_log_level branch January 30, 2023 06:10
@mochizuki875 mochizuki875 reopened this Jan 30, 2023
@mochizuki875
Copy link
Member Author

/assign @adrianludwin

Copy link
Contributor

@adrianludwin adrianludwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
/lgtm
/approve

Thanks for this change!

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 10, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adrianludwin, mochizuki875

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 10, 2023
@k8s-ci-robot k8s-ci-robot merged commit 3b24ea1 into kubernetes-sigs:master Feb 10, 2023
@mochizuki875 mochizuki875 deleted the change_log_level branch February 13, 2023 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants