HRQ decimal point value cannot be specified

[mochizuki875]

What happened?

In HierarchicalResourceQuota, decimal point value cannot be specified.
It's allowed in ResourceQuota.

What did you expect to happen?

Decimal point value can be specified as ResourceQuota

How can we reproduce it (as minimally and precisely as possible)?

For example, this will be invalid.

test-hrq.yaml

apiVersion: hnc.x-k8s.io/v1alpha2
kind: HierarchicalResourceQuota
metadata:
  name: test-hrq
  namespace: test
spec:
  hard:
    limits.cpu: 1.5	# invalid 
    limits.memory: 500Mi
    requests.cpu: 1
    requests.memory: 200Mi

$ kubectl apply -f test-hrq.yaml 
The HierarchicalResourceQuota "test-hrq" is invalid: 
* spec.hard.limits.cpu: Invalid value: "number": spec.hard.limits.cpu in body must be of type integer,string: "number"
* <nil>: Invalid value: "": "spec.hard.limits.cpu" must validate at least one schema (anyOf)
* spec.hard.limits.cpu: Invalid value: "number": spec.hard.limits.cpu in body must be of type integer: "number"

If set limits.cpu: "1.5", it works.

[mochizuki875]

I couldn't understand the details, but at least it seems that ResourceQuota.spec.hard and HierarchicalResourceQuota.spec.hard are not exactly the same.

ResourceQuota.spec.hard

$ kubectl explain --recursive ResourceQuota.spec.hard 
KIND:       ResourceQuota
VERSION:    v1

FIELD: hard <map[string]Quantity>:

DESCRIPTION:

HierarchicalResourceQuota.spec.hard

$ kubectl explain --recursive HierarchicalResourceQuota.spec.hard
GROUP:      hnc.x-k8s.io
KIND:       HierarchicalResourceQuota
VERSION:    v1alpha2

FIELD: hard <map[string]Object>:

DESCRIPTION:

We reuse the k8s parsing code in hierarchicalresourcequota_types.go.

hierarchical-namespaces/api/v1alpha2/hierarchicalresourcequota_types.go

Lines 23 to 29 in 168dd7e

	// HierarchicalResourceQuotaSpec defines the desired hard limits to enforce for
	// a namespace and descendant namespaces
	type HierarchicalResourceQuotaSpec struct {
	// Hard is the set of desired hard limits for each named resource
	// +optional
	Hard corev1.ResourceList `json:"hard,omitempty"`
	}

The ResourceQuota's definition is that.

https://github.com/kubernetes/api/blob/1bc03f6ff533896e6c57e5032babe7bdc39848fb/core/v1/types.go#L6267-L6282

However, generated CRD defines the HierarchicalResourceQuota.spec.hard as integer or string.

hierarchical-namespaces/config/crd/bases/hnc.x-k8s.io_hierarchicalresourcequotas.yaml

Lines 38 to 51 in 168dd7e

	spec:
	description: Spec defines the desired quota
	properties:
	hard:
	additionalProperties:
	anyOf:
	- type: integer
	- type: string
	pattern: ^(\+|-)?(([0-9]+(\.[0-9]*)?)|(\.[0-9]+))(([KMGTPE]i)|[numkMGTPE]|([eE](\+|-)?(([0-9]+(\.[0-9]*)?)|(\.[0-9]+))))?$
	x-kubernetes-int-or-string: true
	description: Hard is the set of desired hard limits for each named
	resource
	type: object
	type: object

So it might have something to do with the process of converting _types.go to CRD by controller-gen.
(Maybe it's a CRD constraint?)

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle stale
• Close this issue with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle rotten
• Close this issue with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Reopen this issue with /reopen
• Mark this issue as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

[k8s-ci-robot]

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Reopen this issue with /reopen
• Mark this issue as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.