-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add CSI liveness probe container #866
Conversation
Welcome @zetaab! |
Hi @zetaab. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: zetaab The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@@ -43,6 +43,16 @@ imageTag: | |||
newTag: "v2.3.0" | |||
--- | |||
|
|||
apiVersion: builtin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no idea should this be added to different files as well in images/
folder?
The mode for the node-driver-registrar was added this summer and are in version 2.3.0 and later. Are you using an older version of the registrar? I don't know what our plans are for the csi liveness probe, @mauriciopoppe I feel like we've discussed this but I can't remember. Also, changes like this should got through rc-staging first before stable-master. |
@@ -38,13 +38,13 @@ spec: | |||
mountPath: /csi | |||
- name: registration-dir | |||
mountPath: /registration | |||
livenessProbe: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we would want to leave this liveness probe, to check that registration is still good (the CSI liveness probe won't know about that).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the mode
flag is pretty recent with more background in kubernetes-csi/node-driver-registrar#143, there are two checks that need to be done: checking that node-driver-registrar successfully registered the driver with the kubelet (done with a different running mode of node-driver-registrar) and once the CSI Driver is registered successfully check that the CSI Driver is healthy (done through https://github.com/kubernetes-csi/livenessprobe)
Q: isn't kubernetes-csi/livenessprobe enough?
Unfortunately livenessprobe only restarts the CSI Driver when there might be another issue in node-driver-registrar as described in the issue.
- /csi-node-driver-registrar | ||
- --kubelet-registration-path=/var/lib/kubelet/plugins/pd.csi.storage.gke.io/csi.sock | ||
- --mode=kubelet-registration-probe | ||
- name: liveness-probe |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs an (http) liveness probe on the driver. However, since the pod is running hostNetwork, that consumes a host port which I don't think we want to do by default.
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /close |
@k8s-triage-robot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
-mode
parameter is not valid anymore tocsi-node-driver-registrar
. Also nowadays upstream uses separate container to run liveness probes usingk8s.gcr.io/sig-storage/livenessprobe
imageWhich issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: