-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Pod permissions to resizer rbac #532
Conversation
Hi @saikat-royc. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: saikat-royc The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@saikat-royc: GitHub didn't allow me to request PR reviews from the following users: mattcary. Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
The tests are failing now though, aren't they? Maybe we should get this rbac in and the rollback as appropriate when/if the resizer change is made. |
The canary job that tests latest, unreleased sidecars is the one that's failing. But we can ask to fix this before the next resizer is released. |
/retest |
Gotcha. Makes sense to just fix on external-resizer, then, if it's prompt. |
/retest |
2 similar comments
/retest |
/retest |
@saikat-royc: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Closing this PR. As part of kubernetes-csi/external-resizer#88, the watch for Pod events will be feature gated. |
What type of PR is this?
What this PR does / why we need it:
Update Resizer RBAC rules to watch pod events
Which issue(s) this PR fixes:
Fixes # 531
Special notes for your reviewer:
Does this PR introduce a user-facing change?: