Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Pod permissions to resizer rbac #532

Closed
wants to merge 1 commit into from

Conversation

saikat-royc
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
Update Resizer RBAC rules to watch pod events
Which issue(s) this PR fixes:

Fixes # 531

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Update Resizer RBAC rules to watch pod events

@k8s-ci-robot k8s-ci-robot added kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 22, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @saikat-royc. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: saikat-royc
To complete the pull request process, please assign davidz627
You can assign the PR to them by writing /assign @davidz627 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 22, 2020
@k8s-ci-robot k8s-ci-robot requested review from saad-ali and verult June 22, 2020 21:11
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 22, 2020
@saikat-royc
Copy link
Member Author

/cc @msau42 @mattcary

@k8s-ci-robot
Copy link
Contributor

@saikat-royc: GitHub didn't allow me to request PR reviews from the following users: mattcary.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @msau42 @mattcary

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot requested a review from msau42 June 22, 2020 21:11
@msau42
Copy link
Contributor

msau42 commented Jun 22, 2020

/ok-to-test
There's an issue open in resizer to make the new pod watch opt-in. So we may not need the new rbacs. kubernetes-csi/external-resizer#88

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 22, 2020
@mattcary
Copy link
Contributor

The tests are failing now though, aren't they? Maybe we should get this rbac in and the rollback as appropriate when/if the resizer change is made.

@msau42
Copy link
Contributor

msau42 commented Jun 22, 2020

The canary job that tests latest, unreleased sidecars is the one that's failing. But we can ask to fix this before the next resizer is released.

@saikat-royc
Copy link
Member Author

/retest

@mattcary
Copy link
Contributor

The canary job that tests latest, unreleased sidecars is the one that's failing. But we can ask to fix this before the next resizer is released.

Gotcha. Makes sense to just fix on external-resizer, then, if it's prompt.

@saikat-royc
Copy link
Member Author

/retest

2 similar comments
@saikat-royc
Copy link
Member Author

/retest

@saikat-royc
Copy link
Member Author

/retest

@k8s-ci-robot
Copy link
Contributor

@saikat-royc: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-gcp-compute-persistent-disk-csi-driver-kubernetes-integration 4b1f28b link /test pull-gcp-compute-persistent-disk-csi-driver-kubernetes-integration

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@saikat-royc
Copy link
Member Author

Closing this PR. As part of kubernetes-csi/external-resizer#88, the watch for Pod events will be feature gated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants