-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ControllerModifyVolume functionality #1801
Conversation
Welcome @travisyx! |
Hi @travisyx. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
/retest |
3 similar comments
/retest |
/retest |
/retest |
/retest |
/test pull-gcp-compute-persistent-disk-csi-driver-kubernetes-integration |
592cb33
to
ea5b26a
Compare
88d7b9f
to
592cb33
Compare
184fec9
to
6aedb32
Compare
@travisyx: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/lgtm According to @amacaskill this is all good except for the known & unrelated arm64 build problem, so I'll force-merge. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mattcary, travisyx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it
This PR implements ControllerModifyVolume. The code changes made allow for hyperdisks which support dynamic provisioning to update the IOPS and Throughput by patching the PVC with a different VolumeAttributesClass. For more information, see here.
Which issue(s) this PR fixes:
Fixes #1693
Special notes for your reviewer:
Does this PR introduce a user-facing change?: