Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nvme path filtering logic for udevadm trigger #1633

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

pwschuurman
Copy link
Contributor

What type of PR is this?
/kind bug

What this PR does / why we need it:
This PR correctly filters out partition paths in /dev/nvme. The search path was updated in PR#1485, however this introduced logic which filtered out all /dev/nvme paths. The result was that the logic to trigger a udev event for a NVMe device did not work as expected.

Which issue(s) this PR fixes:
Fixes regression of search path https://github.com/kubernetes-sigs/gcp-compute-persistent-disk-csi-driver/pull/1485/files

Special notes for your reviewer:
A follow-up PR will introduce an e2e test for a machine type that uses NVMe (current tests use SCSI), to prevent this type of regression in the future.

Does this PR introduce a user-facing change?:

Fixes a regression in the NVMe device search path

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 7, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pwschuurman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 7, 2024
@pwschuurman
Copy link
Contributor Author

/assign @msau42 @Sneha-at

@mattcary
Copy link
Contributor

mattcary commented Mar 7, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 7, 2024
@pwschuurman
Copy link
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit dec1fe5 into kubernetes-sigs:master Mar 7, 2024
7 checks passed
@pwschuurman
Copy link
Contributor Author

/cherrypick release-1.13

@k8s-infra-cherrypick-robot

@pwschuurman: new pull request created: #1634

In response to this:

/cherrypick release-1.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pwschuurman
Copy link
Contributor Author

/cherrypick release-1.12

@k8s-infra-cherrypick-robot

@pwschuurman: new pull request created: #1647

In response to this:

/cherrypick release-1.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pwschuurman
Copy link
Contributor Author

/cherrypick release-1.10

@k8s-infra-cherrypick-robot

@pwschuurman: new pull request created: #1731

In response to this:

/cherrypick release-1.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants