-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix nvme path filtering logic for udevadm trigger #1633
Fix nvme path filtering logic for udevadm trigger #1633
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pwschuurman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
a78bcfb
to
e19fa90
Compare
/lgtm |
/retest |
/cherrypick release-1.13 |
@pwschuurman: new pull request created: #1634 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherrypick release-1.12 |
@pwschuurman: new pull request created: #1647 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherrypick release-1.10 |
@pwschuurman: new pull request created: #1731 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
This PR correctly filters out partition paths in
/dev/nvme
. The search path was updated in PR#1485, however this introduced logic which filtered out all/dev/nvme
paths. The result was that the logic to trigger audev
event for a NVMe device did not work as expected.Which issue(s) this PR fixes:
Fixes regression of search path https://github.com/kubernetes-sigs/gcp-compute-persistent-disk-csi-driver/pull/1485/files
Special notes for your reviewer:
A follow-up PR will introduce an e2e test for a machine type that uses NVMe (current tests use SCSI), to prevent this type of regression in the future.
Does this PR introduce a user-facing change?: