-
Notifications
You must be signed in to change notification settings - Fork 486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moving method match to v1alpha2 example #742
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: robscott The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
c44ffdb
to
f2ab2ae
Compare
For posterity, that added delay caused this test failure (as desired): https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_gateway-api/742/pull-gateway-api-verify/1422370697329512448. That means we should be able to catch these regressions in the future with this test. I also created an upstream issue to track this: kubernetes/kubernetes#104090. |
Interesting bug. |
+1 Completely agree that it would be nice to flag changes there in PR reviews automatically. Removing hold on this one now that test is passing and temporary fix is in place. /hold cancel |
What type of PR is this?
/kind bug
/kind documentation
What this PR does / why we need it:
Missed this when I was reviewing #733
Does this PR introduce a user-facing change?:
Note: I'm starting this PR to see if I can get
verify-examples-kind
to fail, will update to complete this transition and remove hold at that point./hold