Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving method match to v1alpha2 example #742

Merged
merged 1 commit into from
Aug 3, 2021

Conversation

robscott
Copy link
Member

@robscott robscott commented Aug 3, 2021

What type of PR is this?
/kind bug
/kind documentation

What this PR does / why we need it:
Missed this when I was reviewing #733

Does this PR introduce a user-facing change?:

NONE

Note: I'm starting this PR to see if I can get verify-examples-kind to fail, will update to complete this transition and remove hold at that point.

/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/bug Categorizes issue or PR as related to a bug. kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 3, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: robscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 3, 2021
@robscott robscott force-pushed the example-fix branch 2 times, most recently from c44ffdb to f2ab2ae Compare August 3, 2021 01:36
@robscott
Copy link
Member Author

robscott commented Aug 3, 2021

For posterity, that added delay caused this test failure (as desired): https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_gateway-api/742/pull-gateway-api-verify/1422370697329512448. That means we should be able to catch these regressions in the future with this test. I also created an upstream issue to track this: kubernetes/kubernetes#104090.

@hbagdi
Copy link
Contributor

hbagdi commented Aug 3, 2021

Interesting bug.
Regarding adding to v1a1 examples, I wish there was an automated way to flag if that directory was edited at all in a PR review.
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 3, 2021
@robscott
Copy link
Member Author

robscott commented Aug 3, 2021

+1 Completely agree that it would be nice to flag changes there in PR reviews automatically. Removing hold on this one now that test is passing and temporary fix is in place.

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 3, 2021
@k8s-ci-robot k8s-ci-robot merged commit 06a8183 into kubernetes-sigs:master Aug 3, 2021
@robscott robscott deleted the example-fix branch January 8, 2022 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants