Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding conflict resolution guidance for equivalent rules within a route #620

Merged
merged 1 commit into from
Apr 22, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion apis/v1alpha1/httproute_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -179,13 +179,18 @@ type HTTPRouteRule struct {
//
// * The longest matching hostname.
// * The longest matching path.
// * The largest number of header matches
// * The largest number of header matches.
//
// If ties still exist across multiple Routes:
// * The oldest Route based on creation timestamp. For example, a Route with
// a creation timestamp of "2020-09-08 01:02:03" is given precedence over
// a Route with a creation timestamp of "2020-09-08 01:02:04".
// * The Route appearing first in alphabetical order (namespace/name) for
// example, foo/bar is given precedence over foo/baz.
//
// If ties still exist within the Route that has been given precedence:
// * The first matching rule meeting the above criteria.
hbagdi marked this conversation as resolved.
Show resolved Hide resolved
//
// +optional
// +kubebuilder:validation:MaxItems=8
// +kubebuilder:default={{path:{ type: "Prefix", value: "/"}}}
Expand Down
15 changes: 9 additions & 6 deletions config/crd/bases/networking.x-k8s.io_httproutes.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.