Adding gateway-api category and age column to CRDs #592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/cleanup
k8s-ci-robot
added
the
approved
howardjohn
reviewed
Mar 19, 2021
robscott
force-pushed
the
crd-categories
branch
from
62bf73d
to
e1a5276
Compare
robscott
changed the title
robscott
changed the title
howardjohn
approved these changes
Mar 19, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: howardjohn, robscott, stevesloka The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@robscott Any reason for leaving |
|
Thanks for catching that @hbagdi! BackendPolicy is included now. |
|
This is really great, nice work @robscott. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This adds a gateway-api category to our CRDs as well as a new "age" column for "kubectl get" output.
Which issue(s) this PR fixes:
Fixes #589
Also inspired by #588
Does this PR introduce a user-facing change?: