Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add conformance profile for NGINX Gateway Fabric #3149

Merged
merged 3 commits into from
Jun 11, 2024
Merged

Add conformance profile for NGINX Gateway Fabric #3149

merged 3 commits into from
Jun 11, 2024

Conversation

kate-osborn
Copy link
Contributor

What type of PR is this?
/area conformance

What this PR does / why we need it:
Updates conformance profile for NGINX Gateway Fabric.

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. area/conformance cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 11, 2024
@k8s-ci-robot k8s-ci-robot requested review from arkodg and youngnick June 11, 2024 17:31
@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 11, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @kate-osborn. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kate-osborn kate-osborn mentioned this pull request Jun 11, 2024
Closed
robscott
robscott reviewed Jun 11, 2024
View reviewed changes
Copy link
Member

@robscott robscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kate-osborn! This is great to see!

/approve

conformance/reports/v1.1.0/nginxinc-nginx-gateway-fabric/README.md Outdated

| API channel | Implementation version | Mode | Report |
|-------------|--------------------------------------------------------------------------------|------|------------------------------|
| x | [v1.3.0](https://github.com/nginxinc/nginx-gateway-fabric/releases/tag/v1.3.0) | x | [link](./v1.3.0-report.yaml) |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the name of this report should change per #3148.

/cc @mlavacca

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, here is the naming we must follow for reports with Gateway API version >=1.1 https://github.com/kubernetes-sigs/gateway-api/blob/main/conformance/reports/README.md

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can rename

@k8s-ci-robot k8s-ci-robot requested a review from mlavacca June 11, 2024 20:53
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kate-osborn, robscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 11, 2024
@robscott
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 11, 2024
@kate-osborn kate-osborn requested a review from robscott June 11, 2024 21:09
@robscott
Copy link
Member

Thanks @kate-osborn!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 11, 2024
@k8s-ci-robot k8s-ci-robot merged commit 239a8ab into kubernetes-sigs:main Jun 11, 2024
8 checks passed
BobyMCbobs pushed a commit to BobyMCbobs/kubernetes-sigs-gateway-api that referenced this pull request Jul 10, 2024
@kate-osborn @BobyMCbobs
Add conformance profile for NGINX Gateway Fabric (kubernetes-sigs#3149)
ea6e598 
* Add conformance profile for NGINX Gateway Fabric

* Update reproduce instructions

* Rename new report according to rules
BobyMCbobs pushed a commit to BobyMCbobs/kubernetes-sigs-gateway-api that referenced this pull request Jul 22, 2024
@kate-osborn @BobyMCbobs
Add conformance profile for NGINX Gateway Fabric (kubernetes-sigs#3149)
04dcef1 
* Add conformance profile for NGINX Gateway Fabric

* Update reproduce instructions

* Rename new report according to rules
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pleshakov pleshakov pleshakov left review comments

@arkodg arkodg Awaiting requested review from arkodg

@youngnick youngnick Awaiting requested review from youngnick

@mlavacca mlavacca Awaiting requested review from mlavacca

@robscott robscott Awaiting requested review from robscott

Assignees

@robscott robscott

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/conformance cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kate-osborn @k8s-ci-robot @robscott @pleshakov @mlavacca