Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

conformance-profile: Remove experimental build tag #2327

Merged
merged 2 commits into from
Aug 28, 2023
Merged

conformance-profile: Remove experimental build tag #2327

merged 2 commits into from
Aug 28, 2023

Conversation

sayboras
Copy link
Contributor

@sayboras sayboras commented Aug 20, 2023 •
edited
Loading

What type of PR is this?

/kind test
/area conformance

What this PR does / why we need it:

Which issue(s) this PR fixes:

Relates: #2242

Does this PR introduce a user-facing change?:

NONE

Testing was done as part of cilium/cilium#27596

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. kind/test area/conformance cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 20, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @sayboras. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sayboras sayboras marked this pull request as ready for review August 20, 2023 12:05
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 20, 2023
@shaneutt
Copy link
Member

/cc @sunjayBhatia @mlavacca @kflynn

mlavacca
mlavacca reviewed Aug 21, 2023
View reviewed changes
Copy link
Member

@mlavacca mlavacca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR, @sayboras!

conformance/apis/v1alpha1/doc.go Outdated Show resolved Hide resolved
@mlavacca
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 21, 2023
kflynn
kflynn suggested changes Aug 21, 2023
View reviewed changes
Copy link
Contributor

@kflynn kflynn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...hmmmm. When I tried a conformance run from the CLI with the experimental build tag enabled, it tried to run TestConformance and then TestExperimentalConformance, and TestExperimentalConformance failed because it was expecting an empty cluster to play in.

This PR leaves both functions intact, and I would expect it to fail because of that. If the idea is that the stuff previously tagged with experimental is now OK to include everywhere, I'd expect to see TestExperimentalConformance go away?

@sayboras
Copy link
Contributor Author

I'd expect to see TestExperimentalConformance go away?

Yes, understand that cleaning up of similar/duplicated code is required to
have a clean conformance test framework, however, such work might delay
v1.0.0 GA release, hence, I only remove the build tag to remove the soft
blocker in this PR. Subsequent cleanup/optimization can be done later.

arkodg
arkodg approved these changes Aug 22, 2023
View reviewed changes
Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks !
/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 22, 2023
@sayboras sayboras force-pushed the tam/remove-experiment-tag branch from d90f0f4 to 231624f Compare August 23, 2023 10:33
@sayboras sayboras requested review from kflynn and mlavacca August 23, 2023 10:34
@sayboras sayboras force-pushed the tam/remove-experiment-tag branch from 231624f to d0c1ce1 Compare August 23, 2023 10:35
@sayboras
conformance-profile: Remove experimental build tag
f9a8505 
This is to make it easier for some implementation that imports the
conformance test framework and run tests in the same codebase.

Understand that cleaning up of similar/duplicated code is required to
have a clean conformance test framework, however, such work might delay
v1.0.0 GA release, hence, I only remove the build tag to remove the soft
blocker in this PR. Subsequent cleanup/optimization can be done later.

Relates: kubernetes-sigs#2242
Signed-off-by: Tam Mach <[email protected]>
@sayboras sayboras force-pushed the tam/remove-experiment-tag branch from d0c1ce1 to f9a8505 Compare August 23, 2023 12:28
@sayboras
Copy link
Contributor Author

The previous CI failure was due to recent renaming in main (e.g. HTTPExtendedFeatures -> HTTPRouteExtendedFeatures). The current failure seems to be unrelated to this PR.

@mlavacca
Copy link
Member

@sayboras, the linter is complaining. It looks like you need to do some go and yaml linting.

@sayboras
Correct linting error
14c1d85 
Signed-off-by: Tam Mach <[email protected]>
@sayboras sayboras force-pushed the tam/remove-experiment-tag branch from bcf09fd to 14c1d85 Compare August 26, 2023 00:01
@shaneutt shaneutt requested a review from arkodg August 28, 2023 16:47
@shaneutt shaneutt linked an issue Aug 28, 2023 that may be closed by this pull request
Conformance Profiles: Remove experimental build tag #2242
Closed
@shaneutt shaneutt added the release-blocker MUST be completed to complete the milestone label Aug 28, 2023
shaneutt
shaneutt approved these changes Aug 28, 2023
View reviewed changes
Copy link
Member

@shaneutt shaneutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 28, 2023
@shaneutt shaneutt added this to the v0.8.0 milestone Aug 28, 2023
arkodg
arkodg approved these changes Aug 28, 2023
View reviewed changes
Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: arkodg, sayboras, shaneutt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 4f8e572 into kubernetes-sigs:main Aug 28, 2023
@sayboras sayboras deleted the tam/remove-experiment-tag branch August 29, 2023 03:20
@mlavacca mlavacca mentioned this pull request Sep 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arkodg arkodg arkodg approved these changes

@shaneutt shaneutt shaneutt approved these changes

@LiorLieberman LiorLieberman Awaiting requested review from LiorLieberman

@michaelbeaumont michaelbeaumont Awaiting requested review from michaelbeaumont

@keithmattix keithmattix Awaiting requested review from keithmattix

@sunjayBhatia sunjayBhatia Awaiting requested review from sunjayBhatia

@kflynn kflynn Awaiting requested review from kflynn

@mlavacca mlavacca Awaiting requested review from mlavacca

Assignees

@shaneutt shaneutt

@arkodg arkodg

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/conformance cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/test lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-blocker MUST be completed to complete the milestone release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
No open projects
Gateway API: The Road to GA
Status: Done
Milestone
v0.8.0
Development

Successfully merging this pull request may close these issues.

Conformance Profiles: Remove experimental build tag
6 participants
@sayboras @k8s-ci-robot @shaneutt @mlavacca @kflynn @arkodg