-
Notifications
You must be signed in to change notification settings - Fork 490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log Generation / Observed generation. #1761
Conversation
@briantkennedy: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @briantkennedy. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps one small change to the output, but yeah looks good 👍
While waiting for GatewayClass to be ready, log the Generation / ObservedGeneration since it gives a useful signal on whether the controller is stuck, or trying to converge forever.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thank you!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: briantkennedy, shaneutt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Log Generation / Observed generation.
While waiting for GatewayClass to be ready, log the Generation / ObservedGeneration since it gives a useful signal on whether the controller is stuck, or trying to converge forever.
/kind cleanup
/kind tet
/area conformance
What this PR does / why we need it:
Improve conformance debug.
Which issue(s) this PR fixes:
Minor improvement, no issue filed.
Does this PR introduce a user-facing change?: