Add condition in Failed accepted reasons

[Sajiyah-Salat]

Issue #1670

The condition needs to be added in order to prevent crossname-space parentref

[k8s-ci-robot]

Welcome @Sajiyah-Salat!

It looks like this is your first PR to kubernetes-sigs/gateway-api 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/gateway-api has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @Sajiyah-Salat. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[gyohuangxin]

/ok-to-test

[mlavacca]

Well, the actual reason is missing here. You should add the Reason AND the documentation. Furthermore:

• the reason needs to be CamelCase
• just as a recommendation, I'd use something like ParentRefNotPermitted.

[Sajiyah-Salat]

I will make changes accordingly. Thank you for your review.

[Sajiyah-Salat]

I will add documentation and reason help me with programming line.

[Sajiyah-Salat]

Why my build fails. let me know the reason also help me adding that one line. I am kinda confused in that.

[shaneutt]

Why my build fails. let me know the reason also help me adding that one line. I am kinda confused in that.

The reason I'm seeing is:

apis/v1beta1/shared_types.go:296:8: RouteReasonRefNotPermitted redeclared in this block

[Sajiyah-Salat]

I added this line just to have a demo

[Sajiyah-Salat]

What to add instead of this

[shaneutt]

That error suggests you've made a duplicate RouteReasonRefNotPermitted attribute on the struct, which in the diff I can see is true, there are two of them. Attributes on structs are unique, so the code wont compile if there's a duplicate, based on what I'm seeing I think you just need to rename the attribute you created. Perhaps RouteReasonRefNotPermitted -> RouteReasonParentRefNotPermitted? 🤔

[Sajiyah-Salat]

That error suggests you've made a duplicate RouteReasonRefNotPermitted attribute on the struct, which in the diff I can see is true, there are two of them. Attributes on structs are unique, so the code wont compile if there's a duplicate, based on what I'm seeing I think you just need to rename the attribute you created. Perhaps RouteReasonRefNotPermitted -> RouteReasonParentRefNotPermitted? thinking

I have made changes as you suggested still its failing. its complex for me to understand

[mlavacca]

Your code is not properly formatted. Just run go fmt ./...

[shaneutt]

That error suggests you've made a duplicate RouteReasonRefNotPermitted attribute on the struct, which in the diff I can see is true, there are two of them. Attributes on structs are unique, so the code wont compile if there's a duplicate, based on what I'm seeing I think you just need to rename the attribute you created. Perhaps RouteReasonRefNotPermitted -> RouteReasonParentRefNotPermitted? thinking

I have made changes as you suggested still its failing. its complex for me to understand

No worries! As @mlavacca mentioned it looks like you'll need to run go fmt (this is a tool that comes with Golang that automatically formats Go code for you). There's a blog post which describes it here:

https://go.dev/blog/gofmt

Please let us know how we can continue to be helpful, we really appreciate your contribution! 😃

[Sajiyah-Salat]

I have formatted it as suggested. PTAL.

[mlavacca]

I have a final request, then LGTM: can you please move the reason upward between UnsupportedValue and pending? Because ParentRefNotPermitted is used when the condition is false, while pending is when unknown.

[Sajiyah-Salat]

after making any changes to code base we have to run go fmt ./... in order to format the code, right? Also Thanks a lot @mlavacca and @shaneutt. I have made many silly mistakes and you have helped me happily.

[mlavacca]

after making any changes to code base we have to run go fmt ./... in order to format the code, right?

Ideally yes. Doing it ensures that no go fmt errors will be triggered in the CI.

[mlavacca]

Thanks for your contribution @Sajiyah-Salat!

[Sajiyah-Salat]

/assign

[shaneutt]

Thank you for your contribution!

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mlavacca, Sajiyah-Salat, shaneutt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [shaneutt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Sajiyah-Salat]

This pr is special for me as its my first pr. Thank you @mlavacca and @shaneutt for being a great member.