Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternative to get same capability of extensionRef from route match block after discontinuing support for it #1468

Closed
Amila-Rukshan opened this issue Oct 20, 2022 · 6 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@Amila-Rukshan
Copy link
Contributor

Amila-Rukshan commented Oct 20, 2022

What would you like to be added:
With the following GEP, the extension points within Route match block are going to be removed.
https://gateway-api.sigs.k8s.io/geps/gep-820/

If I had the some policy defined and targeted at HTTPRoute resource then it will apply for all the route rules. but previously it was possible to apply for a single rule (that granularity is lost after dropping the extensionRef support from filters).

I would like to suggest a way as below. If we modify the target-ref-api to support custom properties listed under another property with the value of kind property.

kind: SomePolicy
metadata:
  name: ...
spec:
  default:
    type: <type>
    <type>:
      ...              # policy specific properties          
      ...
targetRef:             
    kind: HTTPRoute  
    name: resource-name
    hTTPRoute:
        ruleNames: 
           - my-rule-name-1
apiVersion: gateway.networking.k8s.io/v1alpha2
kind: HTTPRoute
metadata:
  name: httpbin
spec:
  parentRefs:
    - name: eg
  hostnames:
    - "www.example.com"
  rules:
    - name: my-rule-name-1
      backendRefs:
        - group: ""
          kind: Service
          name: httpbin-1
          port: 80
          weight: 1
       matches:
        - path:
            type: PathPrefix
            value: /
    - name: my-rule-name-2
       backendRefs:
        - group: ""
          kind: Service
          name: httpbin-2
          port: 80
          weight: 1
       matches:
        - path:
            type: PathPrefix
            value: /
  

Now the policy is applied to the rule of the HTTPRoute and not all the rules.

Why this is needed:

This will help not to split related http routes (going to the same backend and same filters are applied) into a set of HTTPRoute resources by targeting the policy to the HTTPRouteRule.

@Amila-Rukshan Amila-Rukshan added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 20, 2022
@Amila-Rukshan Amila-Rukshan changed the title Get the capability of extensionRef from route match block How to have the capability of extensionRef from route match block Oct 20, 2022
@Amila-Rukshan Amila-Rukshan changed the title How to have the capability of extensionRef from route match block Alternative to get same capability of extensionRef from route match block after discontinuing support for it Oct 20, 2022
@johnlanni
Copy link

+1

related discussion: #996

@robscott
Copy link
Member

Hey @Amila-Rukshan is there a specific kind of matching you'd like to enable? Wherever possible, we're trying to define common APIs for matching, as long as the concept is broadly implementable.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 13, 2023
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Mar 15, 2023
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

@k8s-ci-robot k8s-ci-robot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 14, 2023
@k8s-ci-robot
Copy link
Contributor

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
No open projects
Development

No branches or pull requests

5 participants