Skip to content

Commit

Permalink
Nit: grammar
Browse files Browse the repository at this point in the history
  • Loading branch information
caboteria committed Aug 2, 2022
1 parent 98cd15c commit e345956
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions site-src/geps/gep-1058.md
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ The remainder of this document covers the proposed enhancements to the Gateway A
## Parent/Child Route Relationships

The proposal is to allow the settings in a child route to be combined with a
section of the parent route’s RouteRule. A HTTPRouteRule may have either
section of the parent route’s RouteRule. An HTTPRouteRule may have either
BackendRefs or AllowedRoutes set. The effect of this is that a Route can
delegate to other Routes. These routes will be referred to as the parent and
child routes. This model would be more consistent with the current Route to
Expand Down Expand Up @@ -473,7 +473,7 @@ status:
```
We add a new `grandparents` stanza inside the the top-level `parents` status. This stanza will be `+optional` and `omitempty`, with the following rules:
- `grandparents` will be nil in all non-parent HTTPRoutes.
- Once a HTTPRoute is a parent, then this stanza must also be non-nil.
- Once an HTTPRoute is a parent, then this stanza must also be non-nil.

We need to add this inside the parents stanza because it's possible that a parent HTTPRoute may be attached to more than one parent (probably Gateways) of its own, and there may be different status between different Gateways. For example, if a parent HTTPRoute is attached to two Gateways, one of which has a wildcard hostname, whether or not the child HTTPRoute attempting to attach to the parent HTTPRoute will be accepted is dependent on the hostname setting on the Gateway Listener. An example demonstrating this is included below.

Expand Down Expand Up @@ -945,7 +945,7 @@ Gateway API community.

There are multiple other documents, GitHub Issues and discussions that are
directly related to this topic and influenced the design of this GEP. This
include the following:
includes the following:

- [Request Filtering Between Gateways and Namespaced Routes · Issue #634 · kubernetes-sigs/gateway-api (github.com)](https://github.com/kubernetes-sigs/gateway-api/issues/634)
- [Request Filtering Between Gateways and Namespaced Routes - Google Docs](https://docs.google.com/document/d/1-0mgRRAY784OgGQ1_LCOshpLLbeAtIr4eXd0YVYK4RY/edit#heading=h.8cfxzle5tmqb)
Expand Down

0 comments on commit e345956

Please sign in to comment.