Skip to content

Commit

Permalink
Cleaning up policy docs in response to PR feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
robscott committed Aug 10, 2021
1 parent cb8e97d commit 4f56cfe
Show file tree
Hide file tree
Showing 3 changed files with 28 additions and 14 deletions.
6 changes: 3 additions & 3 deletions apis/v1alpha2/policy_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -42,19 +42,19 @@ type PolicyTargetReference struct {

// Namespace is the namespace of the referent. When unspecified, the local
// namespace is inferred. Even when policy targets a resource in a different
// namespace, it may only apply to traffic originating from the same
// namespace, it MUST only apply to traffic originating from the same
// namespace as the policy.
//
// +kubebuilder:validation:MinLength=1
// +kubebuilder:validation:MaxLength=253
// +optional
Namespace string `json:"namespace,omitempty"`
Namespace *string `json:"namespace,omitempty"`

// ClassName is the name of the class this policy should apply to. When
// unspecified, the policy will apply to all classes that support it.
//
// +kubebuilder:validation:MinLength=1
// +kubebuilder:validation:MaxLength=253
// +optional
ClassName string `json:"className,omitempty"`
ClassName *string `json:"className,omitempty"`
}
10 changes: 10 additions & 0 deletions apis/v1alpha2/zz_generated.deepcopy.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

26 changes: 15 additions & 11 deletions site-src/v1alpha2/references/policy-attachment.md
Original file line number Diff line number Diff line change
@@ -1,10 +1,12 @@
# Policy Attachment

Many implementations of the API support additional functionality that is not
covered by the API directly. For example, concepts like timeouts, retries, or
even CDN configuration are not sufficiently portable to be defined within the
Gateway API. Instead, implementations may choose to represent these concepts
with custom Policy resources.
While features like timeouts, retries, and custom health checks are present in
most implementations, their details vary since there are no standards (RFCs)
around them. This makes these features less portable. So instead of pulling
these into the API, we offer a middle ground: a standard way to plug these
features in the API and offer a uniform UX across implementations. This standard
approach for policy attachment allows implementations to create their own custom
policy resources that can essentially extend Gateway API.

Policies attached to Gateway API resources and implementations must use the
following approach to ensure consistency across implementations of the API.
Expand All @@ -22,8 +24,9 @@ have been applied to a given resource.
## Policy Attachment for Ingress
Attaching policy to Gateway resources for ingress use cases is relatively
straightforward. A policy can reference the resource it wants to apply to.
Access is granted with RBAC - anyone that has access to create a RetryPolicy in
a given namespace can attach it to any resource within that namespace.
Access is granted with RBAC - for example, anyone that has access to create a
RetryPolicy in a given namespace can attach it to any resource within that
namespace.

![Simple Ingress Example](/images/policy/ingress-simple.png)

Expand Down Expand Up @@ -62,12 +65,13 @@ resources such as Gateways or Namespaces that may apply to multiple child
resources.

The `targetRef` field MUST be an exact replica of the `PolicyTargetReference`
struct included in the Gateway API. Where possible, we recommend using that
struct directly instead of duplicating the type.
struct included in the Gateway API. Where possible, it is recommended to use
that struct directly instead of duplicating the type.

### Policy Boilerplate
The following structure can be used as a starting point for any Policy resource
using this API pattern.
The following structure MUST be used as for any Policy resource using this API
pattern. Within the spec, policy resources may omit `Override` or `Default`
fields, but at least one of them MUST be present.

```go
// ACMEServicePolicy provides a way to apply Service policy configuration with
Expand Down

0 comments on commit 4f56cfe

Please sign in to comment.