Skip to content

Commit

Permalink
Merge pull request #1740 from arkodg/clarify-port-redirect-default
Browse files Browse the repository at this point in the history
Clarify semantics when port_redirect is unset
  • Loading branch information
k8s-ci-robot authored Mar 10, 2023
2 parents be6328d + 4d51132 commit 227de07
Show file tree
Hide file tree
Showing 3 changed files with 70 additions and 30 deletions.
8 changes: 6 additions & 2 deletions apis/v1beta1/httproute_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -882,7 +882,8 @@ type HTTPRequestRedirectFilter struct {

// Hostname is the hostname to be used in the value of the `Location`
// header in the response.
// When empty, the hostname of the request is used.
// When empty, the hostname in the `Host` header
// of the request is used.
//
// Support: Core
//
Expand All @@ -901,7 +902,10 @@ type HTTPRequestRedirectFilter struct {

// Port is the port to be used in the value of the `Location`
// header in the response.
// When empty, port (if specified) of the request is used.
// When empty, the Gateway Listener port is used.
// In all cases, when the protocol is http and the port is port 80,
// then the port must be omitted. Similarly, when the protocol is
// https and the port is port 443, then the port must also be omitted.
//
// Support: Extended
//
Expand Down
46 changes: 32 additions & 14 deletions config/crd/experimental/gateway.networking.k8s.io_httproutes.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

46 changes: 32 additions & 14 deletions config/crd/standard/gateway.networking.k8s.io_httproutes.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 227de07

Please sign in to comment.