Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding required name values #416

Merged
merged 1 commit into from
Dec 10, 2017
Merged

Adding required name values #416

merged 1 commit into from
Dec 10, 2017

Conversation

fabiant7t
Copy link
Contributor

@fabiant7t fabiant7t commented Dec 8, 2017 •
edited
Loading

Added a name value to make Kubernetes 1.8.5 work.

Had this error before:

The Service "nginx" is invalid:
* spec.ports[0].name: Required value

@fabiant7t
Adding required name values
58ea9f9 
Added a name value so make Kubernetes 1.8.5 work.

Had this error before:
```The Service "nginx" is invalid:
* spec.ports[0].name: Required value```
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
  • If you have done the above and are still having issues with the CLA being reported as unsigned, please email the CNCF helpdesk: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 8, 2017
@mikkeloscar
Copy link
Contributor

@fabiant7t please sign the CLA :)

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Dec 8, 2017
@hjacobs hjacobs merged commit 5f88867 into kubernetes-sigs:master Dec 10, 2017
ffledgling pushed a commit to ffledgling/external-dns that referenced this pull request Jan 18, 2018
@fabiant7t @hjacobs
Adding required name values (kubernetes-sigs#416)
874ec1a 
Added a name value so make Kubernetes 1.8.5 work.

Had this error before:
```The Service "nginx" is invalid:
* spec.ports[0].name: Required value```
lou-lan pushed a commit to lou-lan/external-dns that referenced this pull request May 11, 2022
@ahmetb @k8s-ci-robot
Remove license header from krew.yaml (kubernetes-sigs#416)
b38cd8f 
Consistency with other plugin manifests at krew-index repository.

Signed-off-by: Ahmet Alp Balkan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fabiant7t @k8s-ci-robot @mikkeloscar @hjacobs